Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL parameters preserved for attachment queries #187

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 15, 2019

Description:

This extends the attachment URL's to retain arguments that aren't used by Apprise. For example, to download something from dropbox, you'd need a URL like: https://www.dropbox.com/s/pu9ba7rhaierqqo/Avatar-sm.png?dl=1. Prior to this pull request, the dl=1 would become lost.

Parameter arguments are now preserved as long as they don't conflict with the ones Apprise uses (cache=, 'verify=, name=, and mime=).

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-io
Copy link

codecov-io commented Dec 15, 2019

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #187   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          71     71           
  Lines        8314   8323    +9     
  Branches     1330   1333    +3     
=====================================
+ Hits         8314   8323    +9
Impacted Files Coverage Δ
apprise/attachment/AttachHTTP.py 100% <100%> (ø) ⬆️
apprise/attachment/AttachBase.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a1597...21426fb. Read the comment docs.

@caronc caronc merged commit 408810d into master Dec 15, 2019
@caronc caronc deleted the attachment-kwargs branch December 15, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants