Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushSafer Support #184

Merged
merged 2 commits into from
Dec 9, 2019
Merged

PushSafer Support #184

merged 2 commits into from
Dec 9, 2019

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 7, 2019

Description:

Related issue (if applicable): fixes #183

Adds PushSafe Support

New Service Completion Status

  • apprise/plugins/NotifyPushSafe.py
  • setup.py
    • add new service into the keywords section of the setup() declaration
  • README.md
    • add entry for new service to table (as a quick reference)
  • packaging/redhat/python-apprise.spec
    • add new service into the %global common_description

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Syntax

  • psafer://{privatekey}
  • psafer://{privatekey}/{target}
  • psafer://{privatekey}/{target}/{target2}/{target3}/{targetN}
  • psafers://{privatekey}
  • psafers://{privatekey}/{target}
  • psafers://{privatekey}/{target}/{target2}/{target3}/{targetN}

Since PushSafer supports both http and https it only made sense that Apprise did to. For secure connections make sure to use psafers.

The {privatekey} can be found on your PushSafer dashboard.

If no {target} is specified then all devices are notified.

@caronc caronc changed the title Initial commit of NotifyPushSafer (no testing yet) PushSafer Support Dec 7, 2019
@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #184    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          69     70     +1     
  Lines        7974   8235   +261     
  Branches     1282   1318    +36     
======================================
+ Hits         7974   8235   +261
Impacted Files Coverage Δ
apprise/plugins/NotifyPushSafer.py 100% <100%> (ø)
apprise/plugins/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b8fd4d...169a543. Read the comment docs.

@caronc caronc merged commit a29764c into master Dec 9, 2019
@caronc caronc deleted the 183-pushsafer-support branch December 9, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pushsafer notification
2 participants