Improved voipms:// phone number parsing #1230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #1201
Improved phone number parsing while investigating my own error message I was getting which was incredibly vague:
'status: sms_failed', 'message: The SMS message was not sent'
My support ticket got answered with the response:
After doing this, I was able to send notifications:
![Screenshot from 2024-10-27 09-44-48](https://private-user-images.githubusercontent.com/850374/380505121-e7a23518-c8ab-486b-ae56-357541514962.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDIwMTEsIm5iZiI6MTczODkwMTcxMSwicGF0aCI6Ii84NTAzNzQvMzgwNTA1MTIxLWU3YTIzNTE4LWM4YWItNDg2Yi1hZTU2LTM1NzU0MTUxNDk2Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwNDE1MTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jN2I1OGI1OTVkZjZjYjViMWEwNTlhNGE5MjUxZTBkYmJhMjFlZWVkNGRlMTU2NGZlYjMyYmE1MjVlZjE5Y2E2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.7ukFItHyZ33ME-hgfqHm9z4tpgMJZUql7vrSlT1vBUY)
This PR just improves a bit on the phone number parsing (making it slightly less restrictive); otherwise there is no core changes from previous version.
Checklist
flake8
)Testing
Anyone can help test this source code as follows: