Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print statement in test run function. #1220

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Oct 6, 2024

Description:

In nixpkgs, we've encountered a test failure on x86-64-linux. While starting to investigate this, I noticed that the error message printed didn't have the expected context.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@<this.branch-name>

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  <apprise url related to ticket>

@caronc
Copy link
Owner

caronc commented Oct 6, 2024

Thank you🙏

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (ec368e2) to head (62cc78c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1220   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         148      148           
  Lines       20680    20680           
  Branches     4042     4042           
=======================================
  Hits        20549    20549           
  Misses        121      121           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 4cf74be into caronc:master Oct 6, 2024
14 checks passed
@tjni tjni deleted the fix-test-print branch October 7, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants