Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python v3.6 and EPEL 8 from Apprise #1155

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jul 6, 2024

Description:

Related issue (if applicable): n/a

Python v3.6 has been cumbersome to maintain. A lot of patch files to maintain with Rocky Linux 8, plus unit testing has all kinds of edge cases that just simply do not work. Logic in the Apprise code has several spots where it reads acts in such a way "IF Python v3.6, then do this instead to remain compatible...."

This PR ends the support for Python 3.6 completely and with that EPEL 8 management.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (6733953) to head (ec814ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1155    +/-   ##
========================================
  Coverage   99.28%   99.28%            
========================================
  Files         142      142            
  Lines       18440    18440            
  Branches     3763     3544   -219     
========================================
  Hits        18309    18309            
  Misses        121      121            
  Partials       10       10            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc force-pushed the drop-python-36-support branch 2 times, most recently from 0f99f5f to 3c610bc Compare July 6, 2024 22:43
@caronc caronc force-pushed the drop-python-36-support branch from 3c610bc to ec814ab Compare July 6, 2024 22:52
@caronc caronc merged commit bca25c9 into master Jul 6, 2024
14 checks passed
@caronc caronc deleted the drop-python-36-support branch July 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant