Turn large ntfy messages into a attachments #1136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): n/a
It was requested on Discord to avoid passing along large ntfy messages since the upstream blocks them. However to simulate what the ntfy cli does, it takes large body/title content and creates an attachment from it. It specifically targets the
JSON body too large
Error message the ntfy server sends back if your message is to large for it.The largest feature introduced into this PR is the introduction of a memory based Attachment file. @joergschultzelutter may appreciate this as he asked for it earlier.
The use case for the memory attachment is so you don't have to write a temporary file to disk and then reference the content as an
AttachFile
Checklist
flake8
)Testing
Anyone can help test this source code as follows: