host
parsed from user login (if present) for Emails
#1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): n/a
This was a report made on Discord where the URL should have worked (imo):
mailtos://?smtp=mobile.charter.net&pass=password&user=name@spectrum.net
Apprise wasn't smart enough to pull the
spectrum.net
hostname from the user login for thehost
until this PR. The user above can still use the URL:mailtos://spectrum.net?smtp=mobile.charter.net&pass=password&user=name@spectrum.net
After this PR, the first URL will work. To avoid ambiguity, emails can now also be specified in the hostname if content was parsed elsewhere; hence the following URL is also valid now:
mailtos://Jason Smith<jsmith%40yahoo.ca>?smtp=mobile.charter.net&pass=password&user=name@spectrum.net
%40
==@
. The idea is if you don't specify a hostname, you're not restricted from putting in your emails you want to transmit to. This becomes theto
and flows with current design.Checklist
flake8
)Testing
Anyone can help test this source code as follows: