Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Free-Mobile Support #1090

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Added Free-Mobile Support #1090

merged 1 commit into from
Mar 30, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Mar 30, 2024

Description

Free Mobile Apprise Support Added

Account Setup

Sign up with Free Mobile (link) and use your credentials (user and pass) to send a notification.

Syntax

Valid syntax is as follows:

  • freemobile://{user}@{password}

New Service Completion Status

  • apprise/plugins/NotifyFreeMobile.py
  • KEYWORDS
    • add new service into this file (alphabetically).
  • README.md
    • add entry for new service to table (as a quick reference)
  • packaging/redhat/python-apprise.spec
    • add new service into the %global common_description

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@free-mobile-support

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  freemobile://user@pass

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (2c5341a) to head (2dc208c).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1090   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         137      138    +1     
  Lines       17901    17954   +53     
  Branches     3657     3663    +6     
=======================================
+ Hits        17771    17824   +53     
  Misses        121      121           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 5b1b7a0 into master Mar 30, 2024
12 checks passed
@caronc caronc deleted the free-mobile-support branch April 6, 2024 15:04
Copy link

@rabonarca rabonarca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work for me. I get an error 400 meaning that a parameter is missing.
I think the msg should be in the payload instead of params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants