Support Asynchronous Dynamic Module Loading #1071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #1020
This is in efforts to address a racing condition that happens in Home Assistant Core/110242
Effectively what this patch does is adds a mutex around the (notification) plugin loading. In addition to this, a flag is tracked when loading has been completed allowing threaded or asynchronous instances of Apprise to work correctly.
Previously (before this patch), the Apprise library would start loading it's (notification) plugins dynamically after first being instantiated. However second instances would not recognize that the first instance hadn't completed loading all the libraries. The second instance would however detect that plugins were loaded (it really depends on how far the first instance got during it's startup) and assumed it was okay to start processing URLs it was fed. If your notification URL referenced a plugin that simply hadn't loaded yet (it's a timing thing), it would flat out fail.
Checklist
flake8
)Testing
Anyone can help test this source code as follows: