housekeeping: sort imports #761
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #761 +/- ##
===========================================
- Coverage 98.13% 98.11% -0.02%
===========================================
Files 15 15
Lines 1123 1117 -6
===========================================
- Hits 1102 1096 -6
Misses 21 21
Continue to review full report at Codecov.
|
tony
force-pushed
the
sort-imports
branch
2 times, most recently
from
743931e to
0611bae
Compare
|
@carltongibson rebased |
There was a problem hiding this comment.
@tony I'm happy with the sorting but I don't like the indentation change.
(I'll add an inline comment for the ones I mean.
| @@ -1,17 +1,15 @@ | |||
| from __future__ import absolute_import | |||
| from __future__ import unicode_literals | |||
| from __future__ import absolute_import, unicode_literals | |||
There was a problem hiding this comment.
This kind of combination is OK
| from django.utils.encoding import force_str | ||
| from django.utils.translation import ugettext_lazy as _ | ||
|
|
||
| from .utils import handle_timezone | ||
| from .widgets import RangeWidget, LookupTypeWidget, CSVWidget, BaseCSVWidget | ||
| from .widgets import BaseCSVWidget, CSVWidget, LookupTypeWidget, RangeWidget |
django_filters/filters.py
Outdated
| ) | ||
| from .fields import (BaseCSVField, BaseRangeField, DateRangeField, | ||
| DateTimeRangeField, IsoDateTimeField, Lookup, | ||
| LookupTypeField, RangeField, TimeRangeField) |
There was a problem hiding this comment.
Even this is OK, although...
|
@carltongibson could you pick one from here? https://isort.readthedocs.io/en/latest/#multi-line-output-modes |
tests/test_filtering.py
Outdated
| ModelMultipleChoiceFilter, | ||
| MultipleChoiceFilter, NumberFilter, | ||
| OrderingFilter, RangeFilter, | ||
| TimeRangeFilter, TypedMultipleChoiceFilter) |
There was a problem hiding this comment.
These I'd prefer One Per Line, with a single indent.
from django_filters.filters import (
AllValue...,
etc
)
tests/test_filters.py
Outdated
| MultipleChoiceFilter, NumberFilter, | ||
| NumericRangeFilter, OrderingFilter, | ||
| RangeFilter, TimeFilter, TimeRangeFilter, | ||
| TypedMultipleChoiceFilter, UUIDFilter) |
There was a problem hiding this comment.
This is the one I don't like.
(One per line with a single indent by preference.)
tests/test_filterset.py
Outdated
| DateRangeFilter, Filter, FilterMethod, | ||
| ModelChoiceFilter, | ||
| ModelMultipleChoiceFilter, NumberFilter, | ||
| UUIDFilter) |
There was a problem hiding this comment.
Again, the change is fine but One Per Line with a single indent. 🙂
|
@carltongibson Just rebased, how do you like it now? |
|
Yes. I like it a lot. 😄 |
| @@ -3,3 +3,6 @@ license-file = LICENSE | |||
|
|
|||
| [wheel] | |||
| universal=1 | |||
|
|
|||
| [isort] | |||
| multi_line_output=3 | |||
|
Annnnnd @carltongibson broke Give me a sec and I'll rebase them. |
|
Yes. Of course I did. Oops. |
housekeeping: sort imports
Run module and tests through isort