Add 'All Day' option, and update Yahoo implementation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yahoo now has an end time `et` parameter which allows it to be handled in a manner more consistent with ics and Google Calendar. calculateEndTime() no longer calls formatTime - it only calculates the end time This was necessary to prevent functionality duplication in the yahoo implementation. The example html file has also been updated.
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an 'All Day' option to enable creating all day events.
Also updated the Yahoo implementation now that there's an et parameter, and updated the example.html to match.
To create an All Day event, just add the option
allDay: true, and set the end date appropriately (a one day event ends the day after it starts).