feat: Watsonx client #45
Conversation
|
There's a codestyle rules in |
| } | ||
| } | ||
|
|
||
| public EventSource getCompletionAsync( |
There was a problem hiding this comment.
Can we write some integration tests for these streaming methods? It will make refactoring easier later on. You can use other int. tests as an example.
src/main/java/ee/carlrobert/llm/client/watsonx/WatsonxClient.java
Outdated
Show resolved
Hide resolved
src/main/java/ee/carlrobert/llm/client/watsonx/completion/WatsonxCompletionResponseError.java
Outdated
Show resolved
Hide resolved
src/main/java/ee/carlrobert/llm/client/watsonx/WatsonxAuthenticator.java
Outdated
Show resolved
Hide resolved
mq200
force-pushed
the
master
branch
3 times, most recently
from
9c90c40
to
3bf1fe7
Compare
|
|
||
| public class WatsonxAuthenticator { | ||
|
|
||
| IBMAuthBearerToken bearerToken; |
There was a problem hiding this comment.
These fields could be private if they're not accessed outside this class
| .addHeader("Content-Type", "application/x-www-form-urlencoded") | ||
| .build(); | ||
| try { | ||
| Response response = client.newCall(request).execute(); |
There was a problem hiding this comment.
I don't consider creating new bearer tokens on object initiation a good practise, please reconsider using a lazy initialization
| } | ||
|
|
||
| // Watsonx API Key | ||
| public WatsonxAuthenticator(String username, String apiKey, |
There was a problem hiding this comment.
The constructor is too complex. Can we break it down into smaller units for better readability?
|
|
||
| private void generateNewBearerToken() { | ||
| try { | ||
| Response response = client.newCall(request).execute(); |
There was a problem hiding this comment.
Resources need to be cleaned up - try (Response response = client.newCall(request).execute())
| .getExpiry()); | ||
| } | ||
| } catch (IOException e) { | ||
| System.out.println(e); |
There was a problem hiding this comment.
Please re-throw the exception with meaningful message
|
|
||
| public String getBearerTokenValue() { | ||
| if (!isZenApiKey && (this.bearerToken == null || (this.bearerToken.getExpiration() * 1000) | ||
| < (new Date().getTime() + 60000))) { |
There was a problem hiding this comment.
The magic number 60000 could be named constant for clarity
| .getMessage(); | ||
| return message == null ? "" : message; | ||
| } catch (Exception ex) { | ||
| System.out.println(ex); |
| WatsonxCompletionParameters parameters; | ||
|
|
||
| public WatsonxCompletionRequest(Builder builder) { | ||
| System.out.println("Model ID: " + builder.modelId); |
Add IBM Watsonx.ai client for use with CodeGPT Watsonx.ai integration