Add support for building on Mac OS X #2433

geohot · 2020-02-03T09:10:50Z

This is all the work of analog-cbarber, I just rebased it on master and submitted the pull request. Would close issue #150

It would be great to have OS X binaries. Should be possible to refactor this to duplicate the build scripts less as well.

What would it take to get this merged?

This change is

This uses a standard UE 4.19 download with one minor addition: copy the GenerateProjectFiles.sh script from a UnrealEngine source tree into the root 4.19 directory. Requires Xcode 9.2, which is the latest version that is compatiable with OSX 10.12.6 (Sierra). Was able to build everything using python2 API. You may need to define a ~/user-config.jam file to describe your Python installations to be able to build boost-python. Still need to figure out how to build more than one version of libboost-python.

Someone was able to make 9.4.1 work (see comment for issue carla-simulator#150), so I will assume anything with version 9.2 or later is ok.

You can run Setup.command with --no-xcode command to use the Linux build tools (Ninja and make).

Had been failing on test for Message exceeding max size.

This fixes the broken python tests, which were failing because the path to the egg was incorrect for the Mac.

update-docs · 2020-02-03T09:10:53Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

geohot · 2020-02-03T09:12:39Z

LibCarla/source/carla/MsgPackAdaptors.h

@@ -105,7 +105,7 @@ namespace adaptor {

  private:

-    template <uint64_t I>
+    template <unsigned long I>


TODO: Make this OS dependent?

geohot · 2020-02-03T09:13:11Z

LibCarla/source/carla/client/BlueprintLibrary.h

@@ -22,8 +22,7 @@ namespace client {
  /// @todo Works as a list but its actually a map. We should assess the use
  /// cases and reconsider this implementation.
  class BlueprintLibrary
-    : public EnableSharedFromThis<BlueprintLibrary>,
-      private NonCopyable {
+    : public EnableSharedFromThis<BlueprintLibrary> {


Changed this due to a complaint about the move constructor, can look more into it.

geohot · 2020-02-03T09:13:30Z

LibCarla/source/carla/road/element/Waypoint.h

@@ -37,7 +37,7 @@ namespace std {

    using argument_type = carla::road::element::Waypoint;

-    using result_type = uint64_t;
+    using result_type = unsigned long;


Gate based on OS?

Is there any problem using uint64_t in Mac?

geohot · 2020-02-03T09:16:39Z

PythonAPI/examples/manual_control_rss.py

-        mono = default_font if default_font in fonts else fonts[0]
-        mono = pygame.font.match_font(mono)
-        self._font_mono = pygame.font.Font(mono, 14)
+        if sys.platform == 'darwin': 


I think this can be removed, pygame works fine on my Mac.

geohot · 2020-02-03T09:16:58Z

LibCarla/source/test/common/test_listview.cpp

@@ -30,13 +30,13 @@ static void TestSequence(carla::ListView<Iterator> view) {
 TEST(listview, sequence) {
  int array[] = {0, 1, 2, 3, 4, 5};
  TestSequence(MakeListView(array));
-  std::array<int, 6u> std_array = {0, 1, 2, 3, 4, 5};
+  std::array<int, 6u> std_array = {{0, 1, 2, 3, 4, 5}};


Does this need to be changed?

geohot · 2020-02-03T09:17:46Z

Docs/how_to_build_on_mac.md

+# How to build CARLA on Mac OSX 
+
+Note that unlike the Linux build, this one uses the standard Mac compiler tools and
+the standard Unreal Engine 4.21 distribution.


TODO: Change to 4.22

germanros1987 · 2020-02-20T21:52:32Z

Hi @geohot hope things are going well at comma.

Thanks for taking care of this PR. We need to make sure that the existing CIs don't break. Also, if we want to take MacOS seriously, we need to put together new infrastructure for MacOS, so that this effort doesn't die with the next release.

@marcgpuig I know you are busy, but could you please become the champion for this PR? Please, don't let it die.

wuxiaohua1011 · 2020-07-02T23:06:53Z

oh, is this thread dead? anybody still working on it?

germanros1987 · 2020-07-02T23:19:33Z

@wuxiaohua1011, This thread is just complicated, because we don't have a good way to put together a CI for MacOS with GPU support, making the automatic building and testing of a new build system for MacOS a big pain.

@geohot made an effort to build support, but without a proper CI it will be very hard for the CARLA team to maintain it.

Help is more than welcome.

evdoks · 2020-07-23T16:01:42Z

I have tried building Carla on Mac OS 10.15 Catalina with XCode 10 and ended up with a bunch of only virtual member functions can be marked 'override' errors.

E.g.,
carla/Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Walker/WalkerController.h:48:33: error: only virtual member functions can be marked 'override'
I suspect it is caused by using XCode 10 instead of 9.4, as it is recommended in the installation guide. Unfortunately, Mac OS 10.15 Catalina does not support XCode 9.4, so XCode 10 is the only option.

Tried compiling with the latest version of XCode (11.6) and it breaks in the very beginning.

analog-cbarber and others added 30 commits August 16, 2018 15:41

Add mac build instructions

e069582

Merge branch 'master' into mac-build-0.9

6c1f4f1

Allow Xcode version >= 9.2 in Mac Setup.command

0bf0356

Someone was able to make 9.4.1 work (see comment for issue carla-simulator#150), so I will assume anything with version 9.2 or later is ok.

On the Mac, build using Xcode by default

ac2759f

You can run Setup.command with --no-xcode command to use the Linux build tools (Ninja and make).

Merge branch 'master' into mac-build-0.9

4ca1f03

Fix LibCarla tests for mac builds (issue carla-simulator#150)

6a596cb

Had been failing on test for Message exceeding max size.

Fix make check for mac build (issue carla-simulator#150)

af117d6

This fixes the broken python tests, which were failing because the path to the egg was incorrect for the Mac.

Checkpoint merge from master

9e56a3d

Checkpoint Mac build changes

9a8bc24

Adding missing link commands to setup.py for mac

91e24c4

Workaround pygame font issue on mac in manual_control.py

f04049a

Mac platform settings for Unreal

a55b18f

Merge branch 'master' into mac-build-0.9

65d98f4

conda recipe for python 3.6

f14f8c5

Merge 0.9.4 into mac-build-0.9 branch

b0a12e7

Fix missing braces warning on Mac

75a6daf

Update mac build instructions

39abe9b

fixes

b277478

add quotes

fcd09dc

more quotes

be11ac3

fixups

8c143df

command, not sh

4e8d0bf

didn't need that

e70767b

launch

f9d11b1

attempt to merge

c68027d

setbacks

15036b1

fix version.h issue

f413edd

fix types

164fa11

extra }

44b3e13

geohot commented Feb 3, 2020

View reviewed changes

remove unneeded changes

a112caa

geohot commented Feb 3, 2020

View reviewed changes

geohot added 10 commits February 3, 2020 01:22

recast on os x

092817d

lane detector is dead code

002f603

need recast there too

2f9e44a

a real fix, and a broken thing

5f4ddd3

unify BuildLibCarla

d7425a8

unify BuildPythonAPI

9212464

release and clang-7

544eb2e

unify Package

6c84278

remove dead file

356e15b

python import works now

15b6009

germanros1987 assigned marcgpuig Feb 20, 2020

marcgpuig added backlog build system Changes related to the build system help wanted labels Feb 28, 2020

ben-z mentioned this pull request Mar 27, 2020

Several errors while compiling 0.9.7 on Linux #2416

Closed

germanros1987 mentioned this pull request Jul 31, 2020

[Request] Installation guide is required for MACOS users #3140

Closed

germanros1987 requested a review from bernatx January 26, 2021 20:50

germanros1987 unassigned marcgpuig Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for building on Mac OS X #2433

Add support for building on Mac OS X #2433

geohot commented Feb 3, 2020 •

edited by nsubiron

Loading

update-docs bot commented Feb 3, 2020

geohot Feb 3, 2020

geohot Feb 3, 2020

geohot Feb 3, 2020

marcgpuig Feb 3, 2020

geohot Feb 3, 2020

geohot Feb 3, 2020

geohot Feb 3, 2020 •

edited

Loading

germanros1987 commented Feb 20, 2020

wuxiaohua1011 commented Jul 2, 2020

germanros1987 commented Jul 2, 2020

evdoks commented Jul 23, 2020 •

edited

Loading

Add support for building on Mac OS X #2433

Are you sure you want to change the base?

Add support for building on Mac OS X #2433

Conversation

geohot commented Feb 3, 2020 • edited by nsubiron Loading

update-docs bot commented Feb 3, 2020

geohot Feb 3, 2020

Choose a reason for hiding this comment

geohot Feb 3, 2020

Choose a reason for hiding this comment

geohot Feb 3, 2020

Choose a reason for hiding this comment

marcgpuig Feb 3, 2020

Choose a reason for hiding this comment

geohot Feb 3, 2020

Choose a reason for hiding this comment

geohot Feb 3, 2020

Choose a reason for hiding this comment

geohot Feb 3, 2020 • edited Loading

Choose a reason for hiding this comment

germanros1987 commented Feb 20, 2020

wuxiaohua1011 commented Jul 2, 2020

germanros1987 commented Jul 2, 2020

evdoks commented Jul 23, 2020 • edited Loading

geohot commented Feb 3, 2020 •

edited by nsubiron

Loading

geohot Feb 3, 2020 •

edited

Loading

evdoks commented Jul 23, 2020 •

edited

Loading