Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reenable armv7, aarch64 gnu targets #231

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Try to reenable armv7, aarch64 gnu targets #231

merged 3 commits into from
Jul 23, 2022

Conversation

NobodyXu
Copy link
Member

It has been a long time and the bugs on these targets might already be fixed by cross.

If not, then we can simply wait for release of 0.3.0, which adds support for zig-cc that can cross-compile any C/C++ code easily for any supported target.

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

NobodyXu added 2 commits July 23, 2022 22:50
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu marked this pull request as ready for review July 23, 2022 13:05
@NobodyXu NobodyXu added the PR: improvement PR that improves existing features or code label Jul 23, 2022
@NobodyXu NobodyXu requested a review from passcod July 23, 2022 13:05
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@passcod passcod mentioned this pull request Jul 23, 2022
@NobodyXu NobodyXu merged commit 009a3a6 into cargo-bins:main Jul 23, 2022
@NobodyXu NobodyXu deleted the add-more-targets branch July 23, 2022 14:52
@ryankurte
Copy link
Collaborator

hey sorry for the late follow up but, what are we fixing here? i wouldn't expect to need zig for cross or native cross compilation

@passcod
Copy link
Member

passcod commented Jul 23, 2022

These gnu targets were disabled in #148. Zig isn't required and indeed isn't actually used currently because upstream hasn't released support yet, so it just falls back to default cross images which have been updated since and now support the ztsd libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: improvement PR that improves existing features or code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants