Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dep trust-dns-reslver to v0.23.0 #1432

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Bump dep trust-dns-reslver to v0.23.0 #1432

merged 2 commits into from
Sep 30, 2023

Conversation

NobodyXu
Copy link
Member

Since we no longer enables reqwest/trust-dns-resolver anymore, we don't need to keep this dependency is sync with upstream reqwest.

@NobodyXu
Bump dep trust-dns-reslver to v0.23.0
1ee9665 
Since we no longer enables `reqwest/trust-dns-resolver` anymore, we
don't need to keep this dependency is sync with upstream `reqwest`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from passcod September 30, 2023 00:29
passcod
passcod approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@passcod passcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we go back to enabling it eventually?

@NobodyXu
Copy link
Member Author

NobodyXu commented Sep 30, 2023 •
edited
Loading

will we go back to enabling it eventually?

Once we upstream the changes to trust-dns-resolver or reqwest, then yes, we can re-enable it.

The only reason for re-enabling it is that gix uses it and there's no way of passing an external reqwest::Client into it.
For that to happen, I need to modify reqwest::blocking::Client to take a reqwest::Client (seanmonstar/reqwest#1954) and I also need to allow per-request redirect policy settings.

And then gix also have to support this.

@NobodyXu
Fix compilation
fb9933c 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu enabled auto-merge September 30, 2023 00:47
@NobodyXu NobodyXu added this pull request to the merge queue Sep 30, 2023
Merged via the queue into main with commit a69becc Sep 30, 2023
@NobodyXu NobodyXu deleted the dep/trust-dns-resolver branch September 30, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @passcod