Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google oauth added and working fine #28

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

thisisazeez
Copy link
Collaborator

No description provided.

@thisisazeez
Copy link
Collaborator Author

@roramigator @vinodsharma10x Please review the above code.

@roberto-morado roberto-morado self-requested a review February 5, 2023 15:50
Copy link
Collaborator

@roberto-morado roberto-morado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it; it works fine. However, I had to create the .env file and install missing dependencies, as well as review the code to understand what and how to use it. I believe it would be great if you include a brief description of how to set it up as well as the general functionality; this will serve as a reference for all contributors.

Let me know if you'd want me to wait, or merge this pr, we could push the documentation to the backlog.

@thisisazeez
Copy link
Collaborator Author

Docs folder just created.

@roberto-morado roberto-morado changed the base branch from main to develop February 5, 2023 17:28
@roberto-morado
Copy link
Collaborator

We're gonna need to add the dist directory to the gitignore file to avoid conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants