-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create module via command #1513
Conversation
Host Test Results 1 files ± 0 1 suites ±0 38m 53s ⏱️ + 25m 54s For more details on these errors, see this check. Results for commit ed7c982. ± Comparison against base commit 5828ed8. This pull request removes 1 and adds 113 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
eae7d18
to
afbba2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this locally and I couldn’t get it to generate the application, maybe I didn’t set something up properly?
It does create the new chat, though I had to switch to it. Then it describes what it would create:
It asks for permission to go ahead and I give it (should it be mentioning generateAppModule
?)
It asks again and I say to proceed:
It asks again and finally says it lacks permissions:
On another attempt:
That time it didn’t say it lacked permissions though, it just said it would finish eventually:
I wouldn’t be surprised if I have something incorrectly set up though.
The code and configuration looks good though!
display: inline-block; | ||
width: var(--icon-size); | ||
height: var(--icon-size); | ||
background: url('./ai-assist-icon@2x.webp') no-repeat center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this was already in the styles but when I ran this locally the image was missing 😯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@backspace currently it only appears when using localhost 4201. Probably a good idea to move this icon to boxel-ui and use it from there. Do you know a way to import/reference icon urls from boxel-ui for use in css background-image
property? I generally end up changing it to not be a css property and use the icon directly in the template instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm yes this is confusing, since this PR I would expect glimmer-scoped-css
to be able to handle a reference in the CSS to an asset but when I tried that just now it broke the build 🧐
will examine this further
@backspace Was this populating the "Module" section in the PRD card with the module url or not doing that either? I realize it's not clear from the current chat workflow that that's where the module link would appear. |
ya I noticed that in the screenshots but it didn’t change locally but just now I tried erasing the Synapse data and databases and starting over and it worked 🎉 apologies for the false negative! |
afbba2d
to
e535df8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect the "command-y" stuff in this PR to be reworked as Ian's updated command work lands.
123fa5a
to
71e7278
Compare
71e7278
to
51cff5c
Compare
1- Open a Product Requirements document and click on "Generate App Now" button. A new chat will appear with generated code. Confirm module creation.
2- Generated module is linked on the document. Click on it to open module in code mode.
3- Viewing in code mode. Fix errors if any.
4- (Not within scope) Clicking on "Create New Instance" will create a new app instance.
Open Questions: