Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano Governance overview: new page content #1252

Merged

Conversation

thenic95
Copy link
Contributor

Checklist

  • I have read the How to Contribute.
  • I have run yarn build after adding my changes without getting any errors.

Updating documentation or Bugfix

Add content to page explaining the future governance model of cardano on the governance revamp branch

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Readable version in branch: https://github.com/thenic95/developer-portal/blob/governance-revamp-new/docs/governance/cardano-governance/overview.md)

Nice writing @thenic95 - these corrections are mainly for spelling / capitalisation of key terms & some grammar. Conceptually it looks OK to me but would be nice for @Ryun1 to also review this. 🤓

Too early at this time to add CIP-0108 (cardano-foundation/CIPs#632), but my guess is that this will be merged very soon (awaiting 1 more editorial confirmation) & can be linked with the proper CIP name from "governance actions": either in this PR or in another soon after. Metadata would be too detailed of course, but a definition & scope of a governance action could be helpful to link and/or quote.

docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
docs/governance/cardano-governance/overview.md Outdated Show resolved Hide resolved
@rphair rphair changed the title Add content to page explaining the future governance model of cardano on the governance revamp branch Cardano Governance overview: new page content Apr 17, 2024
thenic95 and others added 9 commits April 23, 2024 09:55
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
@thenic95
Copy link
Contributor Author

Thank you for the review and input @rphair and @Ryun1 🙏

This completes the second task in the Cardano Governance section #1223

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thenic95 awesome 🤩

@rphair rphair merged commit 9ca81ef into cardano-foundation:governance-revamp Apr 23, 2024
1 check passed
rphair added a commit that referenced this pull request Jul 5, 2024
#1284)

* implement new structure for governance section of the developer portal. Change name of the governance section and create placeholder pages. (#1228)

* update Participate in Governance overview for governance section revamp (#1238)

* update Participate in Governance overview for governance section revamp

* Update docs/governance/overview.md

Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>

* Update docs/governance/overview.md

Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>

* Update text about treasury growth rate

---------

Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>

* Cardano Governance overview: new page content (#1252)

* Add content to page explaining the future governance model of cardano

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Update docs/governance/cardano-governance/overview.md

Co-authored-by: Robert Phair <rphair@cosd.com>

* Apply suggestions from code review

Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Robert Phair <rphair@cosd.com>

---------

Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>

* Governance Section Revamp - Add governance action overview page (#1263)

* Create the Governance Action Overview page, explaining the seven different types of actions as detailed in CIP-1694

* add a description of the page

* Remove Governance tutorials and add a section about SanchoNet (#1276)

---------

Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants