--sync-tolerance to control the tolerance in the sync progress calculation #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
approved these changes
Nov 9, 2019
KtorZ
force-pushed
the
KtorZ/option-sync-tolerance
branch
from
350df7d
to
3450058
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 10, 2019
991: --sync-tolerance to control the tolerance in the sync progress calculation r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I had to bump stack LTS in order to be able to use time formatter and parser on NominalDiffTime from `time-1.9.3` - [x] I made the tolerance a parameter of the `syncProgress` calculation - [x] I've made this parameter accessible all the way down the command-line via `--sync-tolerance` # Comments <!-- Additional comments or screenshots to attach if any --> - There's currently no strong integration tests on that. I've only been testing things manually with various sync tolerance. Ideally, I'd add integration tests scenario later... - This comes as a mitigation regarding the syncing "issue" that could occur in Daedalus as discussed with ops and QA earlier today. We'll try to measure what could be a good potential value and configure this via the flag. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Build failed |
|
☝️ Weird nix failure unable to build something in the swagger validator. This PR changes nothing about Swagger, and both unit and integration have passed in CI. So merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A
Overview
time-1.9.3syncProgresscalculation--sync-toleranceComments
There's currently no strong integration tests on that. I've only been testing things manually with various sync tolerance. Ideally, I'd add integration tests scenario later...
This comes as a mitigation regarding the syncing "issue" that could occur in Daedalus as discussed with ops and QA earlier today. We'll try to measure what could be a good potential value and configure this via the flag.