Make API Golden tests filenames compatible with Windows #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
|
I have checked that these tests now pass on Windows. bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 8, 2019
981: Make API Golden tests filenames compatible with Windows r=rvl a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #703 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have revised api golden test filenames generation to only use alpha-num characters - [x] I have re-generated all api golden tests # Comments <!-- Additional comments or screenshots to attach if any --> ``` $ ls AddressAmountTestnet.json ApiNetworkTip.json ApiTimeReference.json ApiTWalletId.json ByronWalletPostData.json ApiAddressTestnet.json ApiStakePool.json ApiTPassphraseencryption.json ApiTWalletName.json PostTransactionDataTestnet.json ApiBlockReference.json ApiStakePoolMetrics.json ApiTransactionTestnet.json ApiTWalletPassphraseInfo.json PostTransactionFeeDataTestnet.json ApiByronWallet.json ApiTAddressPoolGap.json ApiTSyncProgress.json ApiTxId.json WalletPostData.json ApiByronWalletMigrationInfo.json ApiTAddressProxyNetworkDiscriminantTestnet.json ApiTTxStatus.json ApiUtxoStatistics.json WalletPutData.json ApiFee.json ApiTDirection.json ApiTWalletBalance.json ApiWallet.json WalletPutPassphraseData.json ApiNetworkInformation.json ApiTHashTx.json ApiTWalletDelegationApiTPoolId.json ApiWalletPassphrase.json ``` <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build failed |
|
The build failed due to #931. Retrying... bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 8, 2019
981: Make API Golden tests filenames compatible with Windows r=rvl a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #703 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have revised api golden test filenames generation to only use alpha-num characters - [x] I have re-generated all api golden tests # Comments <!-- Additional comments or screenshots to attach if any --> ``` $ ls AddressAmountTestnet.json ApiNetworkTip.json ApiTimeReference.json ApiTWalletId.json ByronWalletPostData.json ApiAddressTestnet.json ApiStakePool.json ApiTPassphraseencryption.json ApiTWalletName.json PostTransactionDataTestnet.json ApiBlockReference.json ApiStakePoolMetrics.json ApiTransactionTestnet.json ApiTWalletPassphraseInfo.json PostTransactionFeeDataTestnet.json ApiByronWallet.json ApiTAddressPoolGap.json ApiTSyncProgress.json ApiTxId.json WalletPostData.json ApiByronWalletMigrationInfo.json ApiTAddressProxyNetworkDiscriminantTestnet.json ApiTTxStatus.json ApiUtxoStatistics.json WalletPutData.json ApiFee.json ApiTDirection.json ApiTWalletBalance.json ApiWallet.json WalletPutPassphraseData.json ApiNetworkInformation.json ApiTHashTx.json ApiTWalletDelegationApiTPoolId.json ApiWalletPassphrase.json ``` <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#703
Overview
Comments