Change the return type of migrateByronWallet to be a list of transactions.
#837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
KtorZ
approved these changes
Oct 16, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 16, 2019
837: Change the return type of `migrateByronWallet` to be a list of transactions. r=KtorZ a=jonathanknowles # Issue Number #779 # Overview The result of migrating funds from a Byron wallet to a new-style wallet will be the creation of _one or more_ transactions. Therefore, it makes sense to report this set of transactions as the result of the `migrateByronWallet` call. This PR merely changes the return type of the call, in order to unblock testing work. Further PRs will actually implement this call. Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>
Build failed |
|
bors r+ |
Merge conflict (retrying...) |
1 similar comment
Merge conflict (retrying...) |
Merge conflict (retrying...) |
Merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#779
Overview
The result of migrating funds from a Byron wallet to a new-style wallet will be the creation of one or more transactions. Therefore, it makes sense to report this set of transactions as the result of the
migrateByronWalletcall.This PR merely changes the return type of the call, in order to unblock testing work.
Further PRs will actually implement this call.