add test Wallet has the same tip as network/information #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Oct 15, 2019
| sync <- getNetworkInfo | ||
| verify sync [ expectFieldEqual DSL.syncProgress Ready ] | ||
| r <- getNetworkInfo | ||
| let (Right epochNum) = fmap (epochNumber . tip) (snd r) |
There was a problem hiding this comment.
Suggested change
| let (Right epochNum) = fmap (epochNumber . tip) (snd r) | |
| let epochNum = getFromResponse (#tip . #epochNumber) |
| expectEventually' ctx state Ready w | ||
| expectEventually' ctx (#tip . #epochNumber) epochNum w | ||
| expectEventually' ctx (#tip . #slotNumber) slotNum w | ||
| expectEventually' ctx (#tip . #height) blockHeight w |
piotr-iohk
force-pushed
the
piotr/network-integration-more
branch
from
f0fa3ef
to
1187d2e
Compare
|
bors r+ |
10 tasks
Merge conflict (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 15, 2019
827: Add syncProgressRelativeToCurrentTime helper r=KtorZ a=Anviking # Issue Number #711 # Overview - [x] I made it easier to use `syncProgress` from StakePoolMetrics (or potential other places) by 1. adding a helper `syncProgressRelativeToTime :: SlotParameters -> BlockHeader -> SyncProgress` 2. Adding `slotParams :: BlockchainParameters -> SlotParameters` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 829: add test Wallet has the same tip as network/information r=KtorZ a=piotr-iohk # Issue Number #819 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] add test checking that wallet has the same tip as network/information endpoint # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#819
Overview
Comments