Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block heights in various places of the API (network info, transaction date ...) #825

Merged

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Oct 15, 2019

Issue Number

#819

Overview

  • I have changed the transaction depth to return a quantity of blocks (now that we can correctly track that!)
  • I have added the block height to the ApiBlockReference type, such that it's returned when fetching the network tip and, the transaction dates.

Comments

Feel free to add some more tests.

@KtorZ KtorZ self-assigned this Oct 15, 2019
@KtorZ KtorZ changed the title Ktor z/network information block height Add block heights in various places of the API (network info, transaction date ...) Oct 15, 2019
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@KtorZ KtorZ merged commit f60c9e8 into KtorZ/network-information-cli Oct 15, 2019
@KtorZ KtorZ deleted the KtorZ/network-information-block-height branch October 15, 2019 11:52
@KtorZ KtorZ added this to the Byron Wallet Support milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants