Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation comments in Cardano.Wallet. #680

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

jonathanknowles
Copy link
Member

Issue Number

None.

Overview

Fixes some typos and removes redundant comments from module Cardano.Wallet.

@jonathanknowles jonathanknowles self-assigned this Sep 5, 2019
Haddock apparently doesn't support comments on function parameters
within record types.
@jonathanknowles
Copy link
Member Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 6, 2019
680: Fix documentation comments in `Cardano.Wallet`. r=jonathanknowles a=jonathanknowles

# Issue Number

None.

# Overview

Fixes some typos and removes redundant comments from module `Cardano.Wallet`.

Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 6, 2019

Timed out

@KtorZ
Copy link
Member

KtorZ commented Sep 6, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 6, 2019
672: SQLite: Prepare schema for rollback r=KtorZ a=rvl

Relates to #642 

# Overview

Makes changes to the SQL schema so that all entities can be rolled back.

The AD state tables are split into:
- non-slot state.
- state related to a slot.
- state related to a checkpoint, which will be deleted when the checkpoint is purged.

# Comments

Note that you will need to delete and recreate your wallet dbs after this commit.


680: Fix documentation comments in `Cardano.Wallet`. r=KtorZ a=jonathanknowles

# Issue Number

None.

# Overview

Fixes some typos and removes redundant comments from module `Cardano.Wallet`.

Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 6, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit 3473b42 into master Sep 6, 2019
@KtorZ KtorZ deleted the jonathanknowles/doc-improvements branch September 11, 2019 13:10
@KtorZ KtorZ added this to the Recovery Week - Week 37 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants