Cardano.Wallet.DB.Model #660
Conversation
| -- data store. | ||
| -- Dummy implementation of the database-layer, using 'MVar'. This may be good | ||
| -- for testing to compare with an implementation on a real data store, or to use | ||
| -- when compiling the wallet for targets which don't have SQLite. |
| filterTxHistory :: SortOrder -> Range SlotId -> TxHistory t -> TxHistory t | ||
| filterTxHistory order range = | ||
| filter ((`isWithinRange` range) . slotId . snd . snd) | ||
| . (case order of |
There was a problem hiding this comment.
We could use sortBy + Down instead of sortOn + reverse to traverse the list one time less, if it matters for performance.
There was a problem hiding this comment.
I wanted this code to be as simple and obvious as possible given that inefficiency doesn't matter in this case (particularly not linear slowdowns). So when I cut & pasted this function I was happy to leave it as it was.
| data Database wid s t xprv = Database | ||
| { wallets :: !(Map wid (WalletDatabase s t xprv)) | ||
| -- ^ Wallet-related information. | ||
| , txs :: (Map (Hash "Tx") (Tx t)) |
There was a problem hiding this comment.
Why do we need Txs? And why globally? It is not in your sqlite schema diagram.
There was a problem hiding this comment.
Ah yes, it's not in that diagram because it only has tables/columns relevant to rollback.
But in the full schema, a Tx is just all rows of tx_in and tx_out that share a txid. Because transactions are immutable, they are not attached to any wallet.
Relates to #641.
Overview
Cardano.Wallet.DB.Modelmodule based on both the MVar DBLayer and the QSM tests model.