Use tx max size & estimator to figure out the right input upper-bound in coin selection #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
commented
Jul 12, 2019
| | otherwise = | ||
| return (opt, inps, utxo) | ||
| return (maxN, inps, utxo) | ||
|
|
There was a problem hiding this comment.
Note that most of the changes in this file are because the type for the maxN in the coin selection options was changed from Word64 to Word8 -> Word8. Therefore, the actual maxN is now computed in the root random (or largestFirst function, and passed down to the iteration function as a Word64 to be depleted.
KtorZ
modified the milestones:
Finalize 'Transactions' API endpoints,
Review Coin Selection
7 tasks
rvl
approved these changes
Jul 15, 2019
| coinSelOpts :: CoinSelectionOptions (ErrValidateSelection t) | ||
| coinSelOpts = CoinSelectionOptions | ||
| { maximumNumberOfInputs = 10 | ||
| { maximumNumberOfInputs = estimateMaxNumberOfInputs tl txMaxSize |
| let n = fromIntegral $ maximumNumberOfInputs opt | ||
| let nLargest = take n . L.sortBy (flip $ comparing (coin . snd)) . Map.toList . getUTxO | ||
| let nOuts = fromIntegral $ NE.length outs | ||
| let maxN = fromIntegral $ maximumNumberOfInputs opt (fromIntegral nOuts) |
| -- there's also a soft-limit of 8kb which results in much smaller transactions | ||
| -- in the end. | ||
| softTxMaxSize :: Quantity "byte" Word16 | ||
| softTxMaxSize = Quantity 8192 |
paweljakubas
approved these changes
Jul 15, 2019
paweljakubas
force-pushed
the
KtorZ/462/enable-max-input
branch
from
58583f1
to
5dc539e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#462
Overview
txMaxSizetoBlockchainParameterestimateMaxNumberOfInputsfrom the transaction layer to replace the hard-coded max number of inputs with a number that's actually relevant.Comments