[ADP-3344] Implement rollBackward for the Deposit Wallet
#4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-rollback
branch
2 times, most recently
from
d699139
to
bbc4d1c
Compare
HeinrichApfelmus
changed the base branch from
master
to
HeinrichApfelmus/ADP-3344/deposit-mock
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-mock
branch
2 times, most recently
from
344d431
to
f28d652
Compare
Base automatically changed from
HeinrichApfelmus/ADP-3344/deposit-mock
to
master
September 19, 2024 09:39
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-rollback
branch
3 times, most recently
from
4aff6d9
to
0990c61
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-rollback
branch
6 times, most recently
from
6a7061d
to
d9d9799
Compare
paolino
requested changes
Sep 30, 2024
| testGenesis :: Read.GenesisData | ||
| testGenesis = undefined | ||
|
|
||
| payFromFaucet :: [(Write.Address, Write.Value)] -> Read.Tx |
There was a problem hiding this comment.
What about other types of txs, like spending from our addresses ?
There was a problem hiding this comment.
I agree, a test that rolling back a spent input works is desirable. I have added a mock function spendOneTxOut and used it.
This is as far as I would like to take testing this feature for now. I'll add documentation for the properties that we would expect on a rollback to the Agda code.
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-rollback
branch
3 times, most recently
from
3a3ed5e
to
3d903f0
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-rollback
branch
from
3d903f0
to
ce1ec9c
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-rollback
branch
from
ce1ec9c
to
e2cdefd
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
This pull request implements the `rollBackward` function for the Deposit Wallet. * We use the `RollbackWindow` data type to decide whether we need to roll back all the way back to genesis. * The `Cardano.Wallet.Deposit.Pure.Submissions` module remains a mock implementation for now. ### Issue Number ADP-3344
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
HeinrichApfelmus
deleted the
HeinrichApfelmus/ADP-3344/deposit-rollback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the
rollBackwardfunction for the Deposit Wallet.RollbackWindowdata type to decide whether we need to roll back all the way back to genesis.Cardano.Wallet.Deposit.Pure.Submissionsmodule remains a mock implementation for now.Issue Number
ADP-3344