Get initial fee policy from the network (Jörmungandr) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for not hard-coding the initial configuration, but retrieve it from the network instead.
Anviking
approved these changes
Jun 25, 2019
| getLinearFee :: Get FeePolicy | ||
| getLinearFee = label "getFeePolicy" $ do | ||
| a <- getWord64be | ||
| b <- getWord64be |
There was a problem hiding this comment.
I think it's a shame to lose the documentation of what the first and second number represent when reading this file, by naming them a and b 🤷♂ If you still prefer a and b, I'm fine with it though.
There was a problem hiding this comment.
Well, they are coefficient in a linear equation, which are usually called a and b, that's why. We could be more verbose though I agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#358
Overview
I have extended the JormungandrLayer to fetch the initial fee configuration from the network. In the long run, we may change this endpoint to fetch more configuration parameters as we see fit.
I have used the new endpoint above during the integration tests setup to retrieve the fee policy from the genesis file instead of using a hard-coded one.
I have renamed and relocated
cardanoPolicytobyronFeePolicyin thehttp-bridgepackageComments