Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Test Scenarios on top of Jörmungandr (Initial Setup) #454

Merged
merged 4 commits into from
Jun 24, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jun 22, 2019

Issue Number

#358

Overview

  • I have updated our genesis.yaml (and re-generated block0.bin) to comply with newer versions of Jörmungandr.
  • I have adjusted the LauncherSpec in Jörmungandr to support running the integration scenarios.
  • I have initialized and started a wallet server using Jörmungandr
  • I have added a dummy integration spec which restores (successfully!) a fixture wallet.

Comments

This is a first draft that spins up a Jormungandr node, and starts a wallet server to talk to it directly.
The setup is definitely simpler than for cardano-sl, and also much faster!

One thing I couldn't do was to generate many UTxOs per wallet. The genesis file in newer versions of
Jormungandr doesn't support having duplicate initial funds. A possible fix would be to generate use the
first 10 addresses of each wallet, instead of re-using the same address.

Jörmungandr Temporary Spec
(Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = 37403204154ae83f78b5141f4089fa197424b189}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiT {getApiT = WalletBalance {available = Quantity 100000000000, total = Quantity 100000000000}}, delegation = ApiT {getApiT = NotDelegating}, name = ApiT {getApiT = WalletName {getWalletName = "Faucet Wallet"}}, passphrase = Just (ApiT {getApiT = WalletPassphraseInfo {lastUpdatedAt = 2019-06-22 15:37:45.169367354 UTC}}), state = ApiT {getApiT = Restoring (Quantity (Percentage {getPercentage = 0}))}}))
  Temporary example spec for Jörmungandr integration

🎉

@KtorZ KtorZ requested a review from paweljakubas June 22, 2019 15:39
@KtorZ KtorZ self-assigned this Jun 22, 2019
# legacy cardano address format
legacy_funds:
- address: 48mDfYyQn21iyEPzCfkATEHTwZBcZJqXhRJezmswfvc6Ne89u1axXsiazmgd7SwT8VbafbVnCvyXhBSMhSkPiCezMkqHC4dmxRahRC86SknFu6JF6hwSg8
value: 123
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on the PR.

@KtorZ KtorZ mentioned this pull request Jun 22, 2019
3 tasks
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice step towards full integration tests with Jormungandr! I see some failures at CI....

@KtorZ KtorZ force-pushed the KtorZ/jormungandr-integration-scenarios-draft branch 2 times, most recently from 8fd5bec to 3347e91 Compare June 24, 2019 09:00
This is a first draft that spins up a Jormungandr node, and starts a wallet server to talk to it directly.
The setup is definitely simpler than for cardano-sl, and also much faster!

One thing I couldn't do was to generate many UTxOs per wallet. The genesis file in newer versions of
Jormungandr doesn't support having duplicate initial funds. A possible fix would be to generate use the
first 10 addresses of each wallet, instead of re-using the same address.
And also move a couple of other 'unsafe' functions there, like
'unsafeRunExceptT' from 'Cardano.Wallet'.
@KtorZ KtorZ force-pushed the KtorZ/jormungandr-integration-scenarios-draft branch from 3347e91 to c6fdc4a Compare June 24, 2019 09:25
@KtorZ KtorZ merged commit 44f8357 into master Jun 24, 2019
@KtorZ KtorZ deleted the KtorZ/jormungandr-integration-scenarios-draft branch June 24, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants