Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CLI --min-log-severity argument with --quiet and --verbose switches. #450

Merged
merged 4 commits into from
Jun 21, 2019

Conversation

jonathanknowles
Copy link
Member

@jonathanknowles jonathanknowles commented Jun 21, 2019

Issue Number

#350

Overview

This PR replaces the --min-log-severity argument with two new switches:

  • --quiet
  • --verbose

These switches have the following semantics:

Switch Help Text Minimum Log Severity Level
--quiet suppress all log output apart from errors Error
--verbose display debugging information in the log output Debug
(none) (default) Info

@jonathanknowles jonathanknowles self-assigned this Jun 21, 2019
@KtorZ KtorZ requested review from KtorZ and rvl June 21, 2019 08:07
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Remains to update our CI to use a version of the bridge supporting this. I've updated my fork (used in CI) and now provide a pre-compiled binary that can be used in Travis:

https://github.com/KtorZ/cardano-http-bridge/releases/tag/v0.0.2

So, let's update travis.yml and remove the old file located inside our repository:

https://github.com/input-output-hk/cardano-wallet/blob/master/.travis.yml#L43-L44

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/user-friendly-log-filtering branch from 56cd703 to 7955783 Compare June 21, 2019 08:25
@jonathanknowles
Copy link
Member Author

So, let's update travis.yml and remove the old file located inside our repository:

https://github.com/input-output-hk/cardano-wallet/blob/master/.travis.yml#L43-L44

This should now be done with the following changes:

@jonathanknowles
Copy link
Member Author

Arf... The file isn't executable?

It seems curl does not set the executable bit. I'm guessing that it doesn't have this capability.

@KtorZ
Copy link
Member

KtorZ commented Jun 21, 2019

I don't think the problem is cURL, the file isn't executable in a first place. Let me fix that 👍

@KtorZ
Copy link
Member

KtorZ commented Jun 21, 2019

@jonathanknowles

$ curl -L https://github.com/KtorZ/cardano-http-bridge/releases/download/v0.0.2/cardano-http-bridge-v0.0.2-x86_64-linux.tar.gz | tar xz -C $HOME/.local/bin
$ ls -lh $HOME/.local/bin/cardano-http-bridge
-rwxr-xr-x 1 ktorz ktorz 12M juin  21 10:43 /home/ktorz/.local/bin/cardano-http-bridge
$ cardano-http-bridge start --help
cardano-http-bridge-start 
start explorer server

USAGE:
    cardano-http-bridge start [FLAGS] [OPTIONS]

FLAGS:
    -h, --help       Prints help information
        --no-sync    disable synchronizing with the upstream network
        --quiet      suppress all log output apart from errors
        --silent     suppress all log output
    -V, --version    Prints version information
        --verbose    display debugging information in the log output

OPTIONS:
        --networks-dir <NETWORKS DIRECTORY>    the relative or absolute directory of the networks to server
        --port <PORT NUMBER>                   set the port number to listen to [default: 80]
        --template <TEMPLATE>...               either 'mainnet' or 'testnet'; may be given multiple times [default: mainnet]

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/user-friendly-log-filtering branch from 7955783 to 3c682a1 Compare June 21, 2019 09:03
@KtorZ KtorZ mentioned this pull request Jun 21, 2019
7 tasks
@jonathanknowles jonathanknowles merged commit e4332e4 into master Jun 21, 2019
@KtorZ KtorZ deleted the jonathanknowles/user-friendly-log-filtering branch June 21, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants