Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3302] Bump runtime node dependency to 8.9.0 #4496

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[ADP-3302] Bump runtime node dependency to 8.9.0 #4496

merged 1 commit into from
Mar 26, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Mar 14, 2024

@paolino paolino added the Conway PRs to prepare to the Conway bump label Mar 14, 2024
@paolino paolino self-assigned this Mar 14, 2024
@paolino paolino force-pushed the paolino/ADP-3322/bump-node-runtime-depenency-to-8.9.0 branch from be5052e to fcd2351 Compare March 25, 2024 16:49
@paolino paolino marked this pull request as ready for review March 25, 2024 16:50
@paolino paolino changed the base branch from master to HeinrichApfelmus/ADP-3302/bump-node-3.9 March 25, 2024 16:50
@HeinrichApfelmus
Copy link
Contributor

What about

cardano-wallet/scripts/release-candidate.sh

Lines 37 to 38 in 631810e

CARDANO_NODE_TAG="8.7.3"
echo "CARDANO_NODE_TAG=$CARDANO_NODE_TAG"

?

@paolino paolino force-pushed the paolino/ADP-3322/bump-node-runtime-depenency-to-8.9.0 branch from fcd2351 to 3fae343 Compare March 25, 2024 18:26
Base automatically changed from HeinrichApfelmus/ADP-3302/bump-node-3.9 to master March 25, 2024 22:31
HeinrichApfelmus
HeinrichApfelmus approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that these are all places where the version number appears. Thanks! 😊

paweljakubas
paweljakubas approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I wonder what would happen if we micro-bump here into 8.9.1

@paolino paolino added this pull request to the merge queue Mar 26, 2024
Merged via the queue into master with commit b8217f4 Mar 26, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3322/bump-node-runtime-depenency-to-8.9.0 branch March 26, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@paolino paolino

Labels
Conway PRs to prepare to the Conway bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolino @HeinrichApfelmus @paweljakubas