Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic changes to join/quitStakePools #4468

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Logic changes to join/quitStakePools #4468

merged 6 commits into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. Update SHELLEY_STAKE_POOLS tests for Conway

    @paweljakubas @HeinrichApfelmus
    paweljakubas authored and HeinrichApfelmus committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    edc022d View commit details
    Browse the repository at this point in the history

  2. Import qualified Cardano.Wallet.IO.Delegation shorthand

    @HeinrichApfelmus
    HeinrichApfelmus committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    84161bb View commit details
    Browse the repository at this point in the history

  3. Add vote to Abstain to joinStakePoolDelegationAction

    @HeinrichApfelmus
    HeinrichApfelmus committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d7872ae View commit details
    Browse the repository at this point in the history

  4. Change guardQuit to allow quitting even when voting

    @HeinrichApfelmus
    HeinrichApfelmus committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    49468a1 View commit details
    Browse the repository at this point in the history

  5. voting/deleg/withdrawal integration tests

    @paweljakubas
    paweljakubas committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3be91e4 View commit details
    Browse the repository at this point in the history

  6. Voting/delegation/withdrawal integration tests (#4476) 

    <!--
Detail in a few bullet points the work accomplished in this PR.

Before you submit, don't forget to:

* Make sure the GitHub PR fields are correct:
   ✓ Set a good Title for your PR.
   ✓ Assign yourself to the PR.
   ✓ Assign one or more reviewer(s).
   ✓ Link to a Jira issue, and/or other GitHub issues or PRs.
   ✓ In the PR description delete any empty sections
     and all text commented in <!--, so that this text does not appear
     in merge commit messages.

* Don't waste reviewers' time:
   ✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped
through.

* Try to make your intent clear:
   ✓ Write a good Description that explains what this PR is meant to do.
   ✓ Jira will detect and link to this PR once created, but you can also
     link this PR in the description of the corresponding Jira ticket.
   ✓ Highlight what Testing you have done.
   ✓ Acknowledge any changes required to the Documentation.
-->

- [x] Voting/revoting after delegation
- [x] Delegation/re-delegation after voting
- [x] Delegation/quitting after voting
- [x] Delegation together with voting
- [x] Quitting after voting
- [x] Withdrawals after voting
- [x] Withdrawals before voting

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number
adp-3261

<!-- Reference the Jira/GitHub issue that this PR relates to, and which
requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->
    @paweljakubas
    paweljakubas authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e7831c3 View commit details
    Browse the repository at this point in the history