-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3288] Extract cardano-wallet-api
cabal package
#4460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
paolino/ADP-3288/extract-unit-cabal
to
master
February 20, 2024 16:46
paweljakubas
reviewed
Mar 8, 2024
paweljakubas
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo conflicts with master
. After you accommodate them and we are green in CI I would say we are good
paolino
force-pushed
the
paolino/ADP-3288/extract-api-cabal
branch
2 times, most recently
from
March 11, 2024 15:46
b2675cd
to
4caf11d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 11, 2024
paolino
force-pushed
the
paolino/ADP-3288/extract-api-cabal
branch
from
March 11, 2024 17:23
4caf11d
to
f1c7824
Compare
paolino
force-pushed
the
paolino/ADP-3288/extract-api-cabal
branch
3 times, most recently
from
March 13, 2024 18:35
dd218e2
to
c097119
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 13, 2024
Also fix some other location changes from previous PRs
paolino
force-pushed
the
paolino/ADP-3288/extract-api-cabal
branch
5 times, most recently
from
March 19, 2024 14:39
2059c88
to
95b4bca
Compare
paolino
force-pushed
the
paolino/ADP-3288/extract-api-cabal
branch
from
March 19, 2024 14:43
95b4bca
to
d66f8bb
Compare
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…nother step in de-cluttering the `cardano-wallet` cabal. As for HLS, with this PR opening together - lib/benchmarks/exe/latency-bench.hs - lib/integration/framework/Test/Integration/Framework/DSL.hs should not create false positives of overlapping instances on the - lib/api/src/Cardano/Wallet/Api/Types.hs - [x] Extract `cardano-wallet-api-http` and `cardano-wallet` exe in the new `cardano-wallet-api` cabal package ADP-3288 Source commit: 1c6f193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step in de-cluttering the
cardano-wallet
cabal.As for HLS, with this PR opening together
should not create false positives of overlapping instances on the
lib/api/src/Cardano/Wallet/Api/Types.hs
Extract
cardano-wallet-api-http
andcardano-wallet
exe in the newcardano-wallet-api
cabal packageADP-3288