Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3288] Extract cardano-wallet-api cabal package #4460

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Feb 20, 2024

Another step in de-cluttering the cardano-wallet cabal.

As for HLS, with this PR opening together

  • lib/benchmarks/exe/latency-bench.hs
  • lib/integration/framework/Test/Integration/Framework/DSL.hs

should not create false positives of overlapping instances on the

  • lib/api/src/Cardano/Wallet/Api/Types.hs

  • Extract cardano-wallet-api-http and cardano-wallet exe in the new cardano-wallet-api cabal package

ADP-3288

@paolino paolino added the CI CI related label Feb 20, 2024
@paolino paolino self-assigned this Feb 20, 2024
Base automatically changed from paolino/ADP-3288/extract-unit-cabal to master February 20, 2024 16:46
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo conflicts with master. After you accommodate them and we are green in CI I would say we are good

@paolino paolino force-pushed the paolino/ADP-3288/extract-api-cabal branch 2 times, most recently from b2675cd to 4caf11d Compare March 11, 2024 15:46
@paolino paolino enabled auto-merge March 11, 2024 16:07
@paolino paolino added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@paolino paolino force-pushed the paolino/ADP-3288/extract-api-cabal branch from 4caf11d to f1c7824 Compare March 11, 2024 17:23
@paolino paolino enabled auto-merge March 11, 2024 17:27
@paolino paolino force-pushed the paolino/ADP-3288/extract-api-cabal branch 3 times, most recently from dd218e2 to c097119 Compare March 13, 2024 18:35
@paolino paolino added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@paolino paolino force-pushed the paolino/ADP-3288/extract-api-cabal branch 5 times, most recently from 2059c88 to 95b4bca Compare March 19, 2024 14:39
@paolino paolino force-pushed the paolino/ADP-3288/extract-api-cabal branch from 95b4bca to d66f8bb Compare March 19, 2024 14:43
@paolino paolino enabled auto-merge March 19, 2024 14:55
@paolino paolino added this pull request to the merge queue Mar 19, 2024
Merged via the queue into master with commit 1c6f193 Mar 19, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3288/extract-api-cabal branch March 19, 2024 16:03
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 19, 2024
…nother step in de-cluttering the `cardano-wallet` cabal. As for HLS, with this PR opening together - lib/benchmarks/exe/latency-bench.hs - lib/integration/framework/Test/Integration/Framework/DSL.hs should not create false positives of overlapping instances on the - lib/api/src/Cardano/Wallet/Api/Types.hs - [x] Extract `cardano-wallet-api-http` and `cardano-wallet` exe in the new `cardano-wallet-api` cabal package ADP-3288 Source commit: 1c6f193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants