Voting integration tests

[paweljakubas]

In order to run Coway tests:

just conway-integration-tests-cabal-match VOTING_TRANSACTIONS

In order to run Babbage test:

just integration-tests-cabal-match TRANS_NEW_CREATE_12

In this PR voting: abstain and no_confidence will be demonstrated.

• Babbage integration test showing error
• Showing voting tx
• Showing re-voting

Voting with delegation tests in separate PR
Voting to DRep in separate PR

Comments

Issue Number

adp-3257

[Anviking]

This will break when a new era is added — let's check _mainEra ctx >= ApiConway instead (or the inverse)

Also — maybe — it might make more sense to say when (_mainEra ctx <= ApiBabbage) $ it ... instead of when ... $ pendingWith ...) as the use of pending otherwise would suggest the test should be fixed.

[paweljakubas]

changed noConway using _mainEra ctx >= ApiConway

[Anviking]

noConway using _mainEra ctx >= ApiConway

Hm. Although if you change noConway, then this symmetry is odd:

Eh. It might be fine 🤷‍♂️ Or maybe it should be preConway or noConwayOrLater instead 🤔

[Anviking]

This will break when a new era is added

Although, this babbage only test is going to become untested very soon after the HF when we stop running integration tests in Babbage, so if it's around for the next era it may be deletable unless intended to be kept for theoretical manual runs 🤔

[Anviking]

I think the response in src should be good enough already and we could drop this

Suggested change

	let getSrcWallet =
	let endpoint = Link.getWallet @'Shelley src
	in request @ApiWallet ctx endpoint Default Empty
	eventually "Wallet is neither voting nor delegating" $ do
	getSrcWallet >>= flip verify

and just verify src instead?

[paweljakubas]

eventually not needed here, you are right

[Anviking]

I think getSrcWallet could go away too if you want when you have src :: ApiWallet. Although the expectField helper in particular would not work when the wallet isn't wrapped with the http response info, so it would have to be

src ^. #delegation `shouldBe`  notDelegating []

[Anviking]

Looks sensible to me! Just one more comment / potential concern on noConway