Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3288] Extract integration cabal #4447

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[ADP-3288] Extract integration cabal #4447

merged 1 commit into from
Feb 19, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Feb 12, 2024 •
edited
Loading

In the journey to make hls work better, we want to remove internal libraries

This is out of band "improvement" but I consider it useful for the task at hand to have reliable tools

ADP-3288

@paolino paolino added the Refactoring No functional changes label Feb 12, 2024
@paolino paolino self-assigned this Feb 12, 2024
Base automatically changed from paolino/ADP-3266/exctract-benchmark-cabal to master February 12, 2024 17:42
@HeinrichApfelmus HeinrichApfelmus force-pushed the paolino/ADP-3288/extract-integration-cabal branch 2 times, most recently from 331f253 to cf6527a Compare February 19, 2024 15:50
@paolino paolino marked this pull request as ready for review February 19, 2024 16:45
@HeinrichApfelmus
Copy link
Contributor

I think that there is a lot of data in test/data that does not belong to the integration tests, but to the unit tests. 🤔 I'm starting to weed this out.

@HeinrichApfelmus HeinrichApfelmus force-pushed the paolino/ADP-3288/extract-integration-cabal branch from cf6527a to bfb1b28 Compare February 19, 2024 18:09
@HeinrichApfelmus HeinrichApfelmus force-pushed the paolino/ADP-3288/extract-integration-cabal branch from bfb1b28 to 2f5449e Compare February 19, 2024 18:19
HeinrichApfelmus
HeinrichApfelmus approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that only the file test/data/token-metadata.json should be moved to the integration tests package.

The rest is looking good. 👍

@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Feb 19, 2024
Merged via the queue into master with commit 144be75 Feb 19, 2024
3 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the paolino/ADP-3288/extract-integration-cabal branch February 19, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Refactoring No functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus