[ADP-3173] Reinstate integration tests for macOS
#4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3173/macos-integration
branch
from
b2de3d1
to
1bad0fd
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3173/macos-integration
branch
from
1bad0fd
to
afc5172
Compare
HeinrichApfelmus
changed the base branch from
master
to
HeinrichApfelmus/ADP-3286/cryptonite
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3286/cryptonite
branch
2 times, most recently
from
8a7bca2
to
82eeaff
Compare
Base automatically changed from
HeinrichApfelmus/ADP-3286/cryptonite
to
master
February 15, 2024 12:43
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3173/macos-integration
branch
from
afc5172
to
e2fee99
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3173/macos-integration
branch
from
e2fee99
to
7cee054
Compare
|
As discussed, I have moved the step of building the integration tests to the pre-merge granularity. Running those tests will still happen at pre-release granularity. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
HeinrichApfelmus
deleted the
HeinrichApfelmus/ADP-3173/macos-integration
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reinstates the macOS integration tests at pre-release granularity.
Comments
The integration tests on macOS are not free of flakiness (e.g. running out of file descriptors), but they can succeed:
For this reason, I propose to run them at pre-release granularity, not at pre-merge granularity.
Issue number
ADP-3173