-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3258] Enable integration tests in Conway era #4410
Merged
paolino
merged 5 commits into
master
from
paolino/ADP-3258/enable-integration-tests-in-conway
Jan 30, 2024
Merged
[ADP-3258] Enable integration tests in Conway era #4410
paolino
merged 5 commits into
master
from
paolino/ADP-3258/enable-integration-tests-in-conway
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
changed the base branch from
master
to
HeinrichApfelmus/ADP-3266/fix-wallet
January 25, 2024 16:49
paolino
force-pushed
the
HeinrichApfelmus/ADP-3266/fix-wallet
branch
from
January 26, 2024 14:59
8a2c5cf
to
787c737
Compare
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
from
January 26, 2024 15:07
84004c8
to
6d584af
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3266/fix-wallet
branch
from
January 26, 2024 15:17
389c28c
to
e215888
Compare
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
3 times, most recently
from
January 26, 2024 15:43
fee4951
to
13d889c
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3266/fix-wallet
branch
from
January 26, 2024 15:49
e215888
to
0c1b972
Compare
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
from
January 26, 2024 15:49
13d889c
to
3922765
Compare
Base automatically changed from
HeinrichApfelmus/ADP-3266/fix-wallet
to
HeinrichApfelmus/ADP-3266/ghc-9.6.3
January 26, 2024 16:10
paolino
force-pushed
the
HeinrichApfelmus/ADP-3266/ghc-9.6.3
branch
from
January 26, 2024 16:14
4d69ef2
to
e7d1167
Compare
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
2 times, most recently
from
January 26, 2024 17:35
23c3cae
to
7727285
Compare
Base automatically changed from
HeinrichApfelmus/ADP-3266/ghc-9.6.3
to
master
January 29, 2024 09:19
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
3 times, most recently
from
January 29, 2024 13:31
04d79e6
to
c49bd41
Compare
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
4 times, most recently
from
January 29, 2024 16:02
be625c7
to
c05d64e
Compare
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
from
January 29, 2024 16:12
c05d64e
to
ec73181
Compare
paolino
force-pushed
the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
from
January 29, 2024 16:25
ec73181
to
61c6037
Compare
HeinrichApfelmus
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😊
Ideally, we would like to use the local-cluster
executable for our integration tests at some point, but perhaps not in this pull request.
Yes, switching to local-cluster executable is something useful but orthogonal to the Conway rush |
paolino
deleted the
paolino/ADP-3258/enable-integration-tests-in-conway
branch
January 30, 2024 08:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noConway
)AsyncExceptions
logging to criticalADP-3258