Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boilerplate from ToText and FromText instances. #434

Merged
merged 8 commits into from
Jun 19, 2019
Merged

Remove boilerplate from ToText and FromText instances. #434

merged 8 commits into from
Jun 19, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jun 18, 2019 •
edited by jonathanknowles
Loading

Issue Number

Re-opened #426 (see #426 (comment))

Overview

In addition to PR #426, this PR:

  • ensures that parsing within fromTextToBoundedEnum is case-sensitive.
  • adds a property test to ensure that fromTextToBoundedEnum t (toTextFromBoundedEnum s a) will fail when s /= t for non-trivial values of a.

See #426

Comments

See #426

@KtorZ KtorZ self-assigned this Jun 18, 2019
@KtorZ KtorZ mentioned this pull request Jun 18, 2019
Closed
4 tasks
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/text-bounded-enum branch from 9364a19 to 7dad152 Compare June 19, 2019 02:05
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/text-bounded-enum branch from 7dad152 to 4058833 Compare June 19, 2019 03:20
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/text-bounded-enum branch from a5bfa22 to f1efb3e Compare June 19, 2019 04:01
@jonathanknowles jonathanknowles self-assigned this Jun 19, 2019
rvl
rvl approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jonathanknowles jonathanknowles merged commit 89f42b8 into master Jun 19, 2019
@KtorZ KtorZ deleted the jonathanknowles/text-bounded-enum branch June 21, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanknowles jonathanknowles jonathanknowles approved these changes

@rvl rvl rvl approved these changes

Assignees

@jonathanknowles jonathanknowles

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KtorZ @jonathanknowles @rvl