-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3224] Bump to node 8.1.2 #4279
Conversation
9e12a25
to
3df56bb
Compare
3df56bb
to
f853343
Compare
b91422e
to
58b2a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you! 👍 😊
I would suggest to pin optparse-applicative
in the cabal.project
in order to facilitate an eventual switch, but I'm not sure if that works here. Worth a try, though.
1b5aa2a
to
29b687f
Compare
9f19fd1
to
6d798ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we're able to bump the run-time dependency on cardano-node
to v 8.1.2 without having to update other dependencies: #4302 .
This pull request should be re-envisioned as a dependency update. For this purpose, I would like to:
- Decouple an update of the Hackage index (potential build plans) from an update of the dependencies proper (actual build plan). This requires specifying version bounds and additional constraints on our part.
- Since
cardano-addresses
is currently unmaintained, we will have to deal with this dependency separately.
6d798ee
to
ba4fa13
Compare
…he `cardano-address`, not `cardano-wallet`
b3acc06
to
509525f
Compare
nix flake update
8.1.1
to8.1.2
cardano-addresses-cli
, runtime dependency is taken from a flake input.Issue Number
ADP-3224