Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3224] Bump to node 8.1.2 #4279

Closed
wants to merge 8 commits into from
Closed

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Nov 29, 2023

  • nix flake update
  • Updated index states for Hackage, CHaP;
  • Changed node version from 8.1.1 to 8.1.2
  • Removed compile-time dependency on the cardano-addresses-cli, runtime dependency is taken from a flake input.

Issue Number

ADP-3224

@Unisay Unisay requested a review from paolino November 29, 2023 17:28
@Unisay Unisay marked this pull request as ready for review November 29, 2023 17:57
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 👍 😊

I would suggest to pin optparse-applicative in the cabal.project in order to facilitate an eventual switch, but I'm not sure if that works here. Worth a try, though.

flake.nix Outdated Show resolved Hide resolved
lib/test-utils/test/Test/Hspec/ExtraSpec.hs Outdated Show resolved Hide resolved
cabal.project Show resolved Hide resolved
@Unisay Unisay added this pull request to the merge queue Dec 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2023
@paolino paolino changed the title Node 8.1.2 [ADP-3224] Bump to node 8.1.2 Dec 4, 2023
@HeinrichApfelmus HeinrichApfelmus force-pushed the yura/ADP-3224/node-8.1.2 branch 3 times, most recently from 9f19fd1 to 6d798ee Compare December 5, 2023 11:05
HeinrichApfelmus

This comment was marked as duplicate.

Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're able to bump the run-time dependency on cardano-node to v 8.1.2 without having to update other dependencies: #4302 .

This pull request should be re-envisioned as a dependency update. For this purpose, I would like to:

  • Decouple an update of the Hackage index (potential build plans) from an update of the dependencies proper (actual build plan). This requires specifying version bounds and additional constraints on our part.
  • Since cardano-addresses is currently unmaintained, we will have to deal with this dependency separately.

@paolino paolino closed this Dec 12, 2023
@paolino paolino deleted the yura/ADP-3224/node-8.1.2 branch December 12, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants