Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3229] Move wallet network implementation to network lib #4264

Merged
merged 8 commits into from
Nov 27, 2023
Merged

[ADP-3229] Move wallet network implementation to network lib #4264

merged 8 commits into from
Nov 27, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Nov 24, 2023 •
edited
Loading

  • Move GenesisParameters to primitive lib
  • Move NetworkParameters to primitive lib
  • Move Byron compatibility modules to primitive lib, rename to Primitive.Ledger.Byron
  • Move Shelley compatibility module to primitive lib , rename to Primitive.Ledger.Shelley
  • Split CompatibilitySpec (because it's containing stuff that has nothing to do with Compatibility module, ehm)
  • Move the CompatibilitySpec part that pertains to Compatibility to primitive lib
  • Split UnliftIO.Compat and move coerceHandlers to network-layer lib
  • Move Ouroboros.Network.Client.Wallet to network-layer lib , rename to Network.Implementation.Ouroboros
  • Move network implementation to network-layer lib and rename as Network.Implementation

ADP-3229

@paolino paolino self-assigned this Nov 24, 2023
@paolino paolino force-pushed the paolino/ADP-3229/move-wallet-network-implementeation-to-network-lib branch 2 times, most recently from 442d8f3 to 6e5d3b1 Compare November 24, 2023 16:21
@paolino paolino marked this pull request as ready for review November 24, 2023 16:21
@paolino paolino force-pushed the paolino/ADP-3229/move-wallet-network-implementeation-to-network-lib branch from 6e5d3b1 to 3b79497 Compare November 24, 2023 16:39
paweljakubas
paweljakubas approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paolino paolino added this pull request to the merge queue Nov 27, 2023
Merged via the queue into master with commit f90a261 Nov 27, 2023
3 checks passed
@paolino paolino deleted the paolino/ADP-3229/move-wallet-network-implementeation-to-network-lib branch November 27, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

@Unisay Unisay Awaiting requested review from Unisay

@HeinrichApfelmus HeinrichApfelmus Awaiting requested review from HeinrichApfelmus

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @paweljakubas