[ADP-3198] Compute primitive block via erafun #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
changed the title
paolino
force-pushed
the
paolino/ADP-3198/add-erafun-for-block-read
branch
from
1848f8a
to
93dd289
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
4e8469c
to
e2a6049
Compare
paolino
force-pushed
the
paolino/ADP-3198/add-erafun-for-block-read
branch
from
93dd289
to
d2a8001
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
3 times, most recently
from
e5730cd
to
fa2892d
Compare
paolino
force-pushed
the
paolino/ADP-3198/add-erafun-for-block-read
branch
from
d2a8001
to
c3c585c
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
fa2892d
to
a80d948
Compare
paolino
force-pushed
the
paolino/ADP-3198/add-erafun-for-block-read
branch
from
c3c585c
to
92372d5
Compare
Base automatically changed from
paolino/ADP-3198/add-erafun-for-block-read
to
master
November 2, 2023 16:04
Unisay
reviewed
Nov 6, 2023
Unisay
reviewed
Nov 6, 2023
Unisay
reviewed
Nov 6, 2023
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
a80d948
to
549ffe3
Compare
paolino
force-pushed
the
paolino/ADP-3198/gen-blocks
branch
4 times, most recently
from
c783671
to
6f7da8d
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
549ffe3
to
d15064b
Compare
paolino
force-pushed
the
paolino/ADP-3198/gen-blocks
branch
from
6f7da8d
to
422226b
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
d15064b
to
6843d86
Compare
paolino
changed the title
paolino
force-pushed
the
paolino/ADP-3198/gen-blocks
branch
4 times, most recently
from
51bfeb8
to
853c577
Compare
paolino
force-pushed
the
paolino/ADP-3198/gen-blocks
branch
from
03d7320
to
d6a1110
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
de10af4
to
2bef83b
Compare
paolino
force-pushed
the
paolino/ADP-3198/gen-blocks
branch
from
d6a1110
to
1d0b62b
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
2bef83b
to
2da4ec4
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
72ae600
to
cde36ec
Compare
paolino
changed the base branch from
master
to
paolino/ADP-3198/simplify-erafun-implementation
HeinrichApfelmus
approved these changes
Nov 13, 2023
paolino
force-pushed
the
paolino/ADP-3198/simplify-erafun-implementation
branch
from
7a87596
to
05d397e
Compare
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
cde36ec
to
23be654
Compare
paolino
force-pushed
the
paolino/ADP-3198/simplify-erafun-implementation
branch
2 times, most recently
from
9103a6d
to
9c320e3
Compare
Use getBlockHeader from Read.Primitive.Block.Header in Node
Use getBlockHeader inplace of toByronBlockHeader in Pools
toShelleyBlockHeader toBabbageBlockHeader toConwayBlockHeader fromBlockNo fromByronHash fromChainHash
paolino
force-pushed
the
paolino/ADP-3198/compute-primitive-block
branch
from
23be654
to
12f133a
Compare
Base automatically changed from
paolino/ADP-3198/simplify-erafun-implementation
to
master
November 13, 2023 17:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromCardanoBlockas an era dependent applicationBenchmark note:
To prove that the change is not damaging performance too much I added a benchmark covering the translation from ledger block to primitive block that compares the previous version against the new one. Because the old version is not more accessible at the end of the PR, this is the link to the commit to checkout and re-run it 4a3c328 via
cabal bench -O2 cardano-wallet:benchmark:era-funADP-3198 ADP-3217