Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Jörmungandr getBlock and getDescendants #369

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Implement Jörmungandr getBlock and getDescendants #369

merged 2 commits into from
Jun 6, 2019

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Jun 5, 2019 •
edited
Loading

Issue Number

#219

Overview

  • I implemented JormungandrLayer getBlock
  • I implemented JormungandrLayer getDescendants

Comments

  • We will test NetworkLayer, not this.
  • I'd recommend reviewing per commit. I can drop one of them if desired.

Skärmavbild 2019-06-05 kl 13 39 30

Skärmavbild 2019-06-05 kl 13 39 47

@Anviking Anviking self-assigned this Jun 5, 2019
@Anviking Anviking force-pushed the anviking/219/jörmungandr-network-3 branch 3 times, most recently from d5f9ea0 to a5e3cf6 Compare June 5, 2019 12:42
@Anviking Anviking requested review from KtorZ and akegalj June 5, 2019 12:43
KtorZ
KtorZ reviewed Jun 5, 2019
View reviewed changes
lib/jormungandr/src/Cardano/Wallet/Jormungandr/Network.hs Outdated

data ErrGetDescendants
= ErrGetDescendantsNetworkUnreachable ErrNetworkUnreachable
| ErrGetDescendantsParentNotFound
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about giving more details and context to errors. Here for instance, it would be nice to know at least which parent isn't found.

akegalj
akegalj reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@akegalj akegalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(Matthiases points are valid though)

@Anviking Anviking force-pushed the anviking/219/jörmungandr-network-3 branch 2 times, most recently from 1209987 to 15d5187 Compare June 6, 2019 14:24
@Anviking Anviking force-pushed the anviking/219/jörmungandr-network-3 branch from 15d5187 to 2bfbd06 Compare June 6, 2019 15:16
@KtorZ KtorZ merged commit dd3c1fb into master Jun 6, 2019
@KtorZ KtorZ deleted the anviking/219/jörmungandr-network-3 branch June 6, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akegalj akegalj akegalj left review comments

@KtorZ KtorZ KtorZ approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anviking @akegalj @KtorZ