Wallet update passphrase integration tests #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 14, 2019 09:41
…d}` and `PUT v2/wallets/{wallet-id}/passphrase`)
piotr-iohk
commented
May 14, 2019
| if (title == "40 chars hex") then | ||
| expectResponseCode @IO HTTP.status403 rup | ||
| else | ||
| expectResponseCode @IO HTTP.status404 rup |
There was a problem hiding this comment.
There is a slight inconsistency in the behavior: There is 403 being returned in case when {wallet-id} is a 40 char long hex encoded string (ofc, for the wallet that does not exist). For any other string it returns 404 (e.g. longer/shorter than 40 chars, 40 char length but not valid hex).
I think I'd be expecting either 404 for all. Or 400 for not valid IDs and 404 for valid and not existing (but this cannot be achieved now #252 (comment))
Not sure if this is something that can be addressed.
There was a problem hiding this comment.
Hmmm... Probably has to do with the way we map the error when a root private key can't be found. I'll have a look at it.
KtorZ
reviewed
May 15, 2019
| } |] | ||
| r <- request @ApiWallet ctx ("POST", "v2/wallets") Default createPayload | ||
| let payload = updatePassPayload oldPass | ||
| (T.pack (replicate passphraseMaxLength '💘')) |
KtorZ
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
PUT v2/wallets/{wallet-id}/passphraseto be inline with API spec (204)410code from the API spec forPUT v2/wallets/{wallet-id}andPUT v2/wallets/{wallet-id}/passphraseas it seems it currently cannot be producedComments