Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use hardfork infrastructure in latency #2046

Merged
merged 5 commits into from
Aug 25, 2020
Merged

use hardfork infrastructure in latency #2046

merged 5 commits into from
Aug 25, 2020

Conversation

paweljakubas
Copy link
Contributor

@paweljakubas paweljakubas commented Aug 17, 2020 •
edited
Loading

Issue Number

#2021

Overview

  • I have added HF infra

Comments

How to run locally now : stack bench cardano-wallet:latency

At this moment I have :

latency: /home/pawel/Work/IOHK/cardano-wallet/lib/shelley/test/data/cardano-node-shelley/faucet-addrs/faucet101.addr: openBinaryFile: does not exist (No such file or directory)

which is surprising, faucet101.addr should not be tried 🤔

@paweljakubas paweljakubas requested a review from rvl August 17, 2020 08:44
@paweljakubas paweljakubas self-assigned this Aug 17, 2020
KtorZ
KtorZ reviewed Aug 17, 2020
View reviewed changes
lib/shelley/bench/Latency.hs Outdated Show resolved Hide resolved
lib/shelley/bench/Latency.hs Outdated Show resolved Hide resolved
@rvl rvl self-assigned this Aug 17, 2020
@KtorZ KtorZ force-pushed the paweljakubas/2021/fix-latency-benchmarks branch from e527deb to 9ad8763 Compare August 24, 2020 12:31
@KtorZ KtorZ requested review from KtorZ and rvl and removed request for rvl August 24, 2020 20:14
@KtorZ KtorZ assigned KtorZ and unassigned rvl Aug 24, 2020
@KtorZ KtorZ added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Aug 24, 2020
@KtorZ
start local cluster only once in latency benchmarks
b62cbe3 
  Previously, was started before each bench although, some state was shared in-memory causing issues for the second bench to run.
@KtorZ KtorZ marked this pull request as ready for review August 24, 2020 20:16
@KtorZ
Copy link
Member

KtorZ commented Aug 24, 2020

Nightly build running here: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/618

@KtorZ
Copy link
Member

KtorZ commented Aug 25, 2020

new build: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/620

@KtorZ KtorZ merged commit 9f93d0a into master Aug 25, 2020
@KtorZ KtorZ deleted the paweljakubas/2021/fix-latency-benchmarks branch August 25, 2020 21:41
@rvl rvl mentioned this pull request Aug 26, 2020
Merged
iohk-bors bot added a commit that referenced this pull request Aug 28, 2020
@iohk-bors @Anviking
@rvl @KtorZ
Merge #2066 #2071 #2080 #2087
5eb1c6f 
2066: Bump cardano-addresses r=rvl a=Anviking

# Issue Number

Release.


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Bump cardano-addresses


# Comments

- I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release

```
Bump includes:
- [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53)
- [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56)
- [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58)
- [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59)
```

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


2071: Minor nix cleanups r=rvl a=rvl

### Issue Number

#2046 #2054

### Overview

- Minor cleanups of nix code for migration tests and latency benchmark.

### Comments

Tested with:
```
nix-build -A benchmarks.cardano-wallet.latency
nix-build nix/migration-tests.nix
```


2080: Also trace the times of stake distribution LSQ queries r=rvl a=Anviking

# Issue Number

#2005 / new issue

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Also measure and trace the times of the LSQ queries in the `stakeDistribution` function


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


2087: Transaction metadata in swagger API spec r=rvl a=rvl

### Issue Number

ADP-307 / #2073 / #2074 

### Overview

Updates the swagger spec for the new metadata field when:
- listing transactions (metadata field is always present but may be null)
- posting a transaction (metadata field is optional)
- estimating fee (as above)

### Comments

[Rendered spec](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/input-output-hk/cardano-wallet/rvl/2073/swagger/specifications/api/swagger.yaml)


Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Co-authored-by: IOHK <devops+stack-project@iohk.io>
Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot added a commit that referenced this pull request Aug 28, 2020
@iohk-bors @Anviking @rvl
Merge #2066 #2071
0a860b1 
2066: Bump cardano-addresses r=rvl a=Anviking

# Issue Number

Release.


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Bump cardano-addresses


# Comments

- I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release

```
Bump includes:
- [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53)
- [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56)
- [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58)
- [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59)
```

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


2071: Minor nix cleanups r=rvl a=rvl

### Issue Number

#2046 #2054

### Overview

- Minor cleanups of nix code for migration tests and latency benchmark.

### Comments

Tested with:
```
nix-build -A benchmarks.cardano-wallet.latency
nix-build nix/migration-tests.nix
```


Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Co-authored-by: IOHK <devops+stack-project@iohk.io>
Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot added a commit that referenced this pull request Aug 28, 2020
@iohk-bors @rvl
Merge #2071
c0e7bc0 
2071: Minor nix cleanups r=rvl a=rvl

### Issue Number

#2046 #2054

### Overview

- Minor cleanups of nix code for migration tests and latency benchmark.

### Comments

Tested with:
```
nix-build -A benchmarks.cardano-wallet.latency
nix-build nix/migration-tests.nix
```


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@rvl rvl Awaiting requested review from rvl

Assignees

@KtorZ KtorZ

@paweljakubas paweljakubas

Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paweljakubas @KtorZ @rvl