widen 'isMigrationError' to catch constraint errors #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On start-up, we run persistent migrations and in case of migration issues, we execute some particular handling (e.g. the pool db resets itself). Yet, we failed at catching migration issues coming from constraints introduced later and that can't be satisfied on already existing data. This commit fixes it. Before ====== [cardano-wallet.network:Info:22] Jörmungandr is ready. cardano-wallet-jormungandr: SQLite3 returned ErrorConstraint while attempting to perform step: NOT NULL constraint failed: pool_owner_backup.pool_owner_index (exiting with an error code) After ===== [cardano-wallet.network:Info:22] Jörmungandr is ready. [cardano-wallet.stake-pool-db:Error:22] Failed to migrate the database: : NOT NULL constraint failed: pool_owner_backup.pool_owner_index [cardano-wallet.stake-pool-db:Notice:22] Non backward compatible database found. Removing old database and re-creating it from scratch. Ignore the previous error. [cardano-wallet.stake-pool-db:Notice:22] 1 migrations were applied to the database. (... and continuing as normal)
jonathanknowles
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
I've tested this going from v2019-12-13 (f3576be) to the current master (10b5512), and it does appear to solve the problem of recreating the stake pool DB:
[cardano-wallet.stake-pool-db:Error:22] [2020-01-14 02:52:08.72 UTC] Failed to migrate the database: : NOT NULL constraint failed: pool_owner_backup.pool_owner_index
[cardano-wallet.stake-pool-db:Notice:22] [2020-01-14 02:52:08.72 UTC] Non backward compatible database found. Removing old database and re-creating it from scratch. Ignore the previous error.I only have a small suggestion regarding naming of the function isMigrationError. (See comments.)
lib/core/src/Cardano/DB/Sqlite.hs
Outdated
| mark = "Database migration: manual intervention required." | ||
| class Exception e => IsMigrationError e where | ||
| -- | Exception predicate for migration errors. | ||
| isMigrationError :: e -> Maybe MigrationError |
There was a problem hiding this comment.
I think the function name isMigrationError is a bit misleading, as the prefix is strongly implies a Boolean result, when what we actually want is to match and extract an error of a particular type (if it exists).
Suggestion: rename this to something like catchMigrationError or matchMigrationError.
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 14, 2020
1261: widen 'isMigrationError' to catch constraint errors r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1251 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> On start-up, we run persistent migrations and in case of migration issues, we execute some particular handling (e.g. the pool db resets itself). Yet, we failed at catching migration issues coming from constraints introduced later and that can't be satisfied on already existing data. This commit fixes it. Before ====== ``` [cardano-wallet.network:Info:22] Jörmungandr is ready. cardano-wallet-jormungandr: SQLite3 returned ErrorConstraint while attempting to perform step: NOT NULL constraint failed: pool_owner_backup.pool_owner_index (exiting with an error code) ``` After ===== ``` [cardano-wallet.network:Info:22] Jörmungandr is ready. [cardano-wallet.stake-pool-db:Error:22] Failed to migrate the database: : NOT NULL constraint failed: pool_owner_backup.pool_owner_index [cardano-wallet.stake-pool-db:Notice:22] Non backward compatible database found. Removing old database and re-creating it from scratch. Ignore the previous error. [cardano-wallet.stake-pool-db:Notice:22] 1 migrations were applied to the database. (... and continuing as normal) ``` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1251
Overview
widen 'isMigrationError' to catch constraint errors
On start-up, we run persistent migrations and in case of migration issues, we
execute some particular handling (e.g. the pool db resets itself). Yet, we
failed at catching migration issues coming from constraints introduced later
and that can't be satisfied on already existing data. This commit fixes it.
Before
After
25fa318
rename 'IsMigration...' to 'MatchMigration...'
9d61437
flatten result after tryJust to a single 'Either'
Comments