Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-use 'deleteWallet' function to avoid logic duplication #1193

Merged
merged 2 commits into from
Dec 16, 2019
Merged

re-use 'deleteWallet' function to avoid logic duplication #1193

merged 2 commits into from
Dec 16, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Dec 16, 2019

Issue Number

#1071

Overview

  • I have re-used 'deleteWallet' function to implement byron delete to avoid logic duplication And seemingly, share fixes when they are done..... !

Comments

@KtorZ
re-use 'deleteWallet' function to avoid logic duplication
159c9f4 
And seemingly, share fixes when they are done
@KtorZ KtorZ requested a review from Anviking December 16, 2019 17:43
@KtorZ KtorZ self-assigned this Dec 16, 2019
paweljakubas
paweljakubas approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KtorZ
Copy link
Member Author

KtorZ commented Dec 16, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 16, 2019
@iohk-bors @KtorZ
Merge #1193
3accdcb 
1193: re-use 'deleteWallet' function to avoid logic duplication r=KtorZ a=KtorZ



# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1071 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have re-used 'deleteWallet' function to implement byron delete to avoid logic duplication And seemingly, share fixes when they are done..... !


# Comments

<!-- Additional comments or screenshots to attach if any -->



<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <matthias.benkort@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 16, 2019

Build failed

@KtorZ
Copy link
Member Author

KtorZ commented Dec 16, 2019

bors retry

iohk-bors bot added a commit that referenced this pull request Dec 16, 2019
@iohk-bors @KtorZ
Merge #1193
530e098 
1193: re-use 'deleteWallet' function to avoid logic duplication r=KtorZ a=KtorZ



# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1071 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have re-used 'deleteWallet' function to implement byron delete to avoid logic duplication And seemingly, share fixes when they are done..... !


# Comments

<!-- Additional comments or screenshots to attach if any -->



<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <matthias.benkort@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 16, 2019

Build failed

@KtorZ
Copy link
Member Author

KtorZ commented Dec 16, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 16, 2019
@iohk-bors @KtorZ
Merge #1193
a6f100d 
1193: re-use 'deleteWallet' function to avoid logic duplication r=KtorZ a=KtorZ



# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1071 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have re-used 'deleteWallet' function to implement byron delete to avoid logic duplication And seemingly, share fixes when they are done..... !


# Comments

<!-- Additional comments or screenshots to attach if any -->



<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <matthias.benkort@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 16, 2019

Build failed

@KtorZ KtorZ force-pushed the KtorZ/1071/byron-wallet-delete-fix branch from 3835ae3 to 2ba1c15 Compare December 16, 2019 18:47
@KtorZ
Copy link
Member Author

KtorZ commented Dec 16, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 16, 2019
@iohk-bors @KtorZ
Merge #1193
b0f6a0d 
1193: re-use 'deleteWallet' function to avoid logic duplication r=KtorZ a=KtorZ



# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1071 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have re-used 'deleteWallet' function to implement byron delete to avoid logic duplication And seemingly, share fixes when they are done..... !


# Comments

<!-- Additional comments or screenshots to attach if any -->



<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <matthias.benkort@gmail.com>
@KtorZ
Copy link
Member Author

KtorZ commented Dec 16, 2019

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 16, 2019

Canceled

@KtorZ KtorZ force-pushed the KtorZ/1071/byron-wallet-delete-fix branch from 2ba1c15 to 4639180 Compare December 16, 2019 18:51
@KtorZ
Copy link
Member Author

KtorZ commented Dec 16, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 16, 2019
@iohk-bors @KtorZ
Merge #1193
f486099 
1193: re-use 'deleteWallet' function to avoid logic duplication r=KtorZ a=KtorZ



# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1071 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have re-used 'deleteWallet' function to implement byron delete to avoid logic duplication And seemingly, share fixes when they are done..... !


# Comments

<!-- Additional comments or screenshots to attach if any -->



<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <matthias.benkort@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 16, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit 4639180 into master Dec 16, 2019
@KtorZ KtorZ deleted the KtorZ/1071/byron-wallet-delete-fix branch December 16, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KtorZ @Anviking @paweljakubas