Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for "active slot coefficient" in apparent performance calculation #1189

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Account for "active slot coefficient" in apparent performance calculation #1189

merged 4 commits into from
Dec 16, 2019

Commits on Dec 16, 2019

  1. Move 'BlockchainParameters' from Primitive.Model -> Primitive.Types 

    1. No reasons it's define in the Model rather than the types (although we should really break this gigantic .Types into smaller pieces)
2. Without this, finding a good home for 'ActiveSlotCoefficient' would have been awkward
    @KtorZ
    KtorZ committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    84c49e4 View commit details
    Browse the repository at this point in the history

  2. add 'ActiveSlotCoefficient' to blockchain parameters

    @KtorZ
    KtorZ committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    3eb5896 View commit details
    Browse the repository at this point in the history

  3. Add extra unit test to pools perf illustrating the influence of f 

    Current fails, as expected:

1) Cardano.Pool.Metrics.calculatePerformances, golden test cases, 100% stake, coeff=0.1, producing 1/10 blocks => p=1.0
     expected: Just 1.0
      but got: Just 0.1
    @KtorZ
    KtorZ committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    7c7dd0a View commit details
    Browse the repository at this point in the history

  4. take 'active slot coefficient' into account in the apparent performan… 

    …ce calculation
    @KtorZ
    KtorZ committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    cb780de View commit details
    Browse the repository at this point in the history