Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAKE_POOLS_ESTIMATE_FEE negative tests for 40x responses #1170

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

#1096

Overview

  • I have added few more tests for 40x responses

Comments

Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 12, 2019
1170: STAKE_POOLS_ESTIMATE_FEE negative tests for 40x responses r=Anviking a=piotr-iohk

# Issue Number

#1096

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have added few more tests  for 40x responses


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 12, 2019

Build failed

@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 12, 2019
1170: STAKE_POOLS_ESTIMATE_FEE negative tests for 40x responses r=Anviking a=piotr-iohk

# Issue Number

#1096

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have added few more tests  for 40x responses


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 12, 2019

Build failed

@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 12, 2019
1170: STAKE_POOLS_ESTIMATE_FEE negative tests for 40x responses r=Anviking a=piotr-iohk

# Issue Number

#1096

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I have added few more tests  for 40x responses


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 12, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit a195046 into master Dec 12, 2019
@Anviking Anviking deleted the piotr/stake-fee-testing branch December 12, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants