Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use another stake pool with metadata in STAKE_POOL_LIST_04 #1169

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

#1065

Overview

  • I thought it will be useful to use the second stake-pool with metadata as well. If anything bad happens, it is more likely to be discovered when there are more pools... I think. (Also added some more comments around the stake pool faucet)

Comments

Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 🤷‍♂️

@KtorZ
Copy link
Member

KtorZ commented Dec 12, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 12, 2019
1141: Jormungandr 0.8.0 rc8 -> 0.8.0 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Jormungandr 0.8.0 rc8 -> 0.8.0
- [x] Update of arbitrary blocks for golden tests
- [x] update of genesis.yaml with optional parameters introduced in 0.8.0 and regenerate genesis block


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


1169: use another stake pool with metadata in STAKE_POOL_LIST_04 r=KtorZ a=piotr-iohk

# Issue Number

#1065

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I thought it will be useful to use the second stake-pool with metadata as well. If anything bad happens, it is more likely to be discovered when there are more pools... I think. (Also added some more comments around the stake pool faucet)


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 12, 2019

Build failed (retrying...)

iohk-bors bot added a commit that referenced this pull request Dec 12, 2019
1169: use another stake pool with metadata in STAKE_POOL_LIST_04 r=KtorZ a=piotr-iohk

# Issue Number

#1065

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] I thought it will be useful to use the second stake-pool with metadata as well. If anything bad happens, it is more likely to be discovered when there are more pools... I think. (Also added some more comments around the stake pool faucet)


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 12, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit 1172bd8 into master Dec 12, 2019
@Anviking Anviking deleted the piotr/stake-metadata-testing branch December 12, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants