-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an extra scenario to illustrate the delegation "latency" #1137
Conversation
411fc25
to
fa090b0
Compare
request @ApiWallet ctx (getWalletEp w) Default Empty >>= flip verify | ||
[ expectFieldSatisfy balanceReward (> 0) | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be worth also to waitForNextEpoch ctx
after the last request/assertion and make sure that the rewards are still the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 48ca283
e5ff524
to
48ca283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bors r+ |
1137: Add an extra scenario to illustrate the delegation "latency" r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #904 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added an extra scenario regarding rewards behavior described below # Comments <!-- Additional comments or screenshots to attach if any --> At epoch e: Join stake pool P1 At epoch e+1: Quit stake pool P1 At epoch e+2: Stake is being delegated to P1 At epoch e+3: Reward is earned from the delegation in e+2 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build failed |
bors r+ |
bors r- |
Canceled |
At epoch e: Join stake pool P1 At epoch e+1: Quit stake pool P1 At epoch e+2: Stake is being delegated to P1 At epoch e+3: Reward is earned from the delegation in e+2
48ca283
to
b70ee87
Compare
bors r+ |
1137: Add an extra scenario to illustrate the delegation "latency" r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #904 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added an extra scenario regarding rewards behavior described below # Comments <!-- Additional comments or screenshots to attach if any --> At epoch e: Join stake pool P1 At epoch e+1: Quit stake pool P1 At epoch e+2: Stake is being delegated to P1 At epoch e+3: Reward is earned from the delegation in e+2 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build succeeded |
Issue Number
#904
Overview
Comments
At epoch e: Join stake pool P1
At epoch e+1: Quit stake pool P1
At epoch e+2: Stake is being delegated to P1
At epoch e+3: Reward is earned from the delegation in e+2